JavaScript refer to a method inside a method?

Question

Ok, just solved one problem where this refered to the wrong scope. Now I have another problem.

So I want to call a method that is inside a method. But I do not know how, check this source:

function someObj() {
   var self = this;

   this.someMethod1 = function() {
      var elementBtn = document.getElementById('myBtn');

      elementBtn.onclick = function() { 
         self.someMethod2.methodMethod(); 
         //I want this.someMethod2.methodMethod() to be called
         //...but I get an big error instead. Is it even possible?
         //this.someMethod2() works fine.

      };
   };
   this.someMethod2 = function() {
      this.methodMethod = function() {
         alert('THIS IS THE ONE I WANTED!');
      };
      alert('NO, NOT THIS!');
   };
}

Error msg:

Uncaught TypeError: Object function () { ...

Andy E · Accepted Answer · 2012-02-07 09:33:14Z

3

With your code, someMethod2 would need to execute first for the function expression to be assigned. Even then, it would be assigned to the parent instance.

Bearing in mind that all functions are objects in JavaScript, this is what you want instead:

this.someMethod2 = function() {
   alert('NO, NOT THIS!');
};
this.someMethod2.methodMethod = function() {
   alert('THIS IS THE ONE I WANTED!');
};

answered Feb 7, 2012 at 9:33

Andy E

346k86 gold badges482 silver badges452 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Gazler · Accepted Answer · 2012-02-07 09:20:01Z

2

You are trying to use an object accessor on a function. If you want it to work in this way, you need to return an object literal from your call to the "outer" function.

this.someMethod2 = function() {
  return {
    methodMethod: function() {
      alert('THIS IS THE ONE I WANTED!');
    }
  }
};

You can then chain the call. self.someMethod2().methodMethod();

answered Feb 7, 2012 at 9:20

Gazler

84.4k18 gold badges285 silver badges245 bronze badges

2 Comments

lejahmie Over a year ago

But then calling just self.someMethod2() wouldn't do much right?

Gazler Over a year ago

Calling self.someMethod2() will return the object literal. You can't have something act as both a function and an object literal.

Ateş Göral · Accepted Answer · 2012-02-07 09:18:28Z

0

While this is not directly possible, you can pass a "command" to the outer function to tell it to execute the inner function. But, are you sure this is what you really need? Perhaps you should use objects instead of functions here. But here's the "command" way:

this.someMethod2 = function(cmd) {
    var methodMethod = function() {
        alert('THIS IS THE ONE I WANTED!');
    };

    if (cmd === "methodMethod") {
        methodMethod();
        return;
    }

    alert('NO, NOT THIS!');
};

answered Feb 7, 2012 at 9:18

Ateş Göral

141k27 gold badges142 silver badges191 bronze badges

1 Comment

lejahmie Over a year ago

Could you give me an example? I am a bit confused with objects and functions in JS. ^^

xdazz · Accepted Answer · 2012-02-07 09:32:56Z

0

function someObj() {
    var self = this;

    this.someMethod1 = function () {
        var elementBtn = document.getElementById('myBtn');

        elementBtn.onclick = function () {
            self.someMethod2().methodMethod();
        };
    };
    this.someMethod2 = function () {
        this.methodMethod = function () {
            alert('THIS IS THE ONE I WANTED!');
        };
        //return this for chain method.
        return this;
    };
}

answered Feb 7, 2012 at 9:32

xdazz

161k38 gold badges255 silver badges278 bronze badges

Comments

Mike · Accepted Answer · 2012-02-07 09:40:07Z

trying

function someObj() {
 var self = this;

 this.someMethod1 = function() {
  var elementBtn = document.getElementById('myBtn');
  elementBtn.onclick = function() { 
      self.someMethod2().methodMethod(); 
  };

 this.someMethod2 = function() {

  this.methodMethod = function() {
     alert('THIS IS THE ONE I WANTED!');
  };
  alert('NO, NOT THIS!');
  return this;
 };
}

Also if you use prototype then

function someObj() {
 var self = this;

  this.someMethod1 = function() {
    var elementBtn = document.getElementById('myBtn');
    elementBtn.onclick = function() { 
      self.someMethod2.methodMethod();//['methodMethod'](); 
    };
   };

   this.someMethod2 = function() {


 };
 this.someMethod2.methodMethod = function() {
     alert('THIS IS THE ONE I WANTED!');
   };
 };

But the method methodMethod is static

Collectives™ on Stack Overflow

JavaScript refer to a method inside a method?

5 Answers 5

Comments

2 Comments

1 Comment

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

2 Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related