Loop only puts last iteration into array, but should have multiple rows [duplicate]

Question

I have a Mysql table which contains a column of JSON data and a column with an amount. The goal is to extract the JSON data and the amount and build an array within the foreach loop. Here is my code:

$sql = "SELECT `Amount`, `NewObject` FROM `mb_cart` WHERE `MyID` = '$id'";
$data_main = $db->query($sql);

Here is my statement that I am using to build the array:

foreach ($data_main as $transaction_main) {
    $json_decoded = json_decode($transaction_main);
    $cart = array('Amount' => $amount, 'CodeType' => $json_decoded->data->Type->data->codeType, 'Name' => $json_decoded->data->Name, 'SiteName' => $json_decoded->data->SiteName);
}

However when I run this, I am only returning only the first record set and the amount is blank, but the JSON data is listed. Appreciate any insight anyone cares to share.

What does $db->query($sql); return? An array or an iterator? See also array_push and the note there, foreach with a reference and iterator_to_array. — hakre
– hakre, Commented Feb 15, 2012 at 14:03

powtac · Accepted Answer · 2012-02-15 14:13:34Z

34

You need to add [] to $cart array. WIth each run of foreach you're overwriting the variable $cart.

something like so would work:

foreach ($data_main as $transaction_main) {
    $json_decoded = json_decode($transaction_main);
        $cart[] = array('Amount' => $amount, 'CodeType' => $json_decoded->data->Type->data->codeType, 'Name' => $json_decoded->data->Name, 'SiteName' => $json_decoded->data->SiteName);
    }

Or if you wanted the array key to match that of the ID of each row:

Note: You will need to set $id variable somehow above IE: SELECT id, amount also note that you COULD potentially have issues if integer from id is non-unique.. eg(1,1,2,3,4,5,6) it will only show the last id of 1 instead of both (since key's are duplicates).

foreach ($data_main as $transaction_main) {
    $json_decoded = json_decode($transaction_main);
        $cart[$id] = array('Amount' => $amount, 'CodeType' => $json_decoded->data->Type->data->codeType, 'Name' => $json_decoded->data->Name, 'SiteName' => $json_decoded->data->SiteName);
    }

edited Feb 15, 2012 at 14:13

powtac

41.1k28 gold badges120 silver badges173 bronze badges

answered Feb 15, 2012 at 13:55

NDBoost

10.7k6 gold badges55 silver badges75 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

user3402040 Over a year ago

I only get $names[$row["nombre"]] = array('id' => $row["id"]); -------Result---------> key = Selección perfil , value = Array , why in value get array ?

Ask Xah Over a year ago

You need to add [] to $cart array <= this helps me a lot. Thanks bro :)

George Cummins · Accepted Answer · 2012-02-15 13:58:06Z

11

Your variable $cart is being overwritten in each loop because you are calling array() each time.

Instead, declare your array outside the loop, and just add values to it as needed:

$cart = array();
foreach ($data_main as $transaction_main) {
    $json_decoded = json_decode($transaction_main);
    $cart[] = array('Amount' => $amount, 'CodeType' => $json_decoded->data->Type->data->codeType, 'Name' => $json_decoded->data->Name, 'SiteName' => $json_decoded->data->SiteName);
}

answered Feb 15, 2012 at 13:58

George Cummins

29k8 gold badges74 silver badges91 bronze badges

Comments

Akhil Thayyil · Accepted Answer · 2012-02-15 13:57:20Z

5

Try this :

$cart=array();
foreach ($data_main as $transaction_main) {
    $json_decoded = json_decode($transaction_main);
        $cart[] = array('Amount' => $amount, 'CodeType' => $json_decoded->data->Type->data->codeType, 'Name' => $json_decoded->data->Name, 'SiteName' => $json_decoded->data->SiteName);
    }

You were treating the cart as a variable instead of array

answered Feb 15, 2012 at 13:57

Akhil Thayyil

9,4256 gold badges38 silver badges48 bronze badges

Comments

472084 · Accepted Answer · 2012-02-15 13:56:36Z

4

$cart = array();

foreach ($data_main as $transaction_main) {
    $json_decoded = json_decode($transaction_main);
    $cart[] = array('Amount' => $amount, 'CodeType' => $json_decoded->data->Type->data->codeType, 'Name' => $json_decoded->data->Name, 'SiteName' => $json_decoded->data->SiteName);
}

print_r($cart);

answered Feb 15, 2012 at 13:56

472084

17.9k10 gold badges67 silver badges82 bronze badges

Comments

Manoj Rammoorthy · Accepted Answer · 2015-08-26 13:05:43Z

0

the way to approach this is first create a variable $cart = array(); and then do foreach(); i have written code below please go through it

foreach($data_main as $transaction_main){
    $json_decoded = json_decoded($transaction_main);
    $cart[]=array('Amount' => $amount, 'CodeType' => $json_decoded->data->Type->data->codeType, 'Name' => $json_decoded->data->Name, 'SiteName' => $json_decoded->data->SiteName);
}

answered Aug 26, 2015 at 13:05

Manoj Rammoorthy

1,43017 silver badges17 bronze badges

Collectives™ on Stack Overflow

Loop only puts last iteration into array, but should have multiple rows [duplicate]

5 Answers 5

2 Comments

Comments

Comments

Comments

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

2 Comments

Comments

Comments

Comments

Comments

Linked

Related