For loop not working correctly

Question

I need the for loop to execute 4 times in the program and then to exit at the fourth time and give the total of the results.

It should not count X as a spoilt vote

The three totals and the number of spoilt votes are initialised to 0.

Now a for loop follows, going from 1 to the number of voting stations.

Inside this loop is a while loop. A prompting message appears on the screen, asking the voter for which candidate he or she wants to vote. The choice of the voter is then input.

Inside the while loop is a switch statement to increment the correct total. The default option is used to count the number of spoilt votes.

The while loop is exited when X is entered for the choice.

When the for loop is exited, the three totals and the number of spoilt votes are displayed.

Here is my code

int main()
{
    const int NR_VOTING_STATIONS = 4;
    int votesForA, votesForB, votesForC, spoiltVotes;
    char vote;

    // initialise totals
    votesForA = 0;
    votesForB = 0;
    votesForC = 0;
    spoiltVotes = 0;

    // LOOP of INTEREST START
    //loop over the voting stations
    for ( int i = 1; i <= NR_VOTING_STATIONS; i++)
    {

        //loop over voters
        while (vote != 'X')
        {
            cout << "Vote for candidate A, B or C : " << endl;
            cin  >> vote;

            switch(vote)
            {
                  case 'A':
                       votesForA++;
                       break;
                  case 'B':
                       votesForB++;
                       break;
                  case 'C':
                       votesForC++;
                       break;
                  default:
                       spoiltVotes++;
            }                     
        }
    }
    // LOOP of INTEREST END

    //display results
    cout << endl  << endl;
    cout << "Total candidate A : " << votesForA   << endl;
    cout << "Total candidate B : " << votesForB   << endl;
    cout << "Total candidate C : " << votesForC   << endl;
    cout << "Total spoilt votes: " << spoiltVotes << endl; 

    system("pause");
    return 0;
}

Thanks

The for loop looks fine to me and will in fact execute four times. So what exactly is your problem? — Joey
– Joey, Commented Mar 25, 2012 at 10:09
What does 'not working correctly' mean? It is of great assistance to the experienced developers here to know exactly what is wrong - what does not happen that should happen, what happens that should not happen, any error messages. Also, you should say what you have done to debug this yourself and what the results of this debugging were. — Martin James
– Martin James, Commented Mar 25, 2012 at 10:12
@Shiplu I guess this is attempt to make part of code bold but SO render engine doesn't support this. I've seen such here multiple times. — Netch
– Netch, Commented Mar 25, 2012 at 10:13

Not_a_Golfer · Accepted Answer · 2012-03-25 10:11:29Z

1

just add in the switch:

case 'X':
    break;

because the while condition will not be executed until the next round.

answered Mar 25, 2012 at 10:11

Not_a_Golfer

49.5k15 gold badges130 silver badges95 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Bernhard · Accepted Answer · 2012-03-25 10:12:54Z

1

If the question is

It should not count X as a spoilt vote

The answer would be to add a case:

case 'X':
     break;

answered Mar 25, 2012 at 10:12

Bernhard

3,7141 gold badge28 silver badges52 bronze badges

Comments

Ed J · Accepted Answer · 2012-03-25 10:37:45Z

1

Also, be careful to initialize vote first, or use do { } while() rather than while { }

answered Mar 25, 2012 at 10:37

Ed J

1012 bronze badges

Comments

tantonj · Accepted Answer · 2012-03-25 10:11:14Z

0

If you need the for loop to execute four times why not just surround it in another for loop?

answered Mar 25, 2012 at 10:11

tantonj

4445 silver badges18 bronze badges

Comments

Tabrez Ahmed · Accepted Answer · 2012-03-25 10:26:05Z

0

In the while loop you should check whether the Voters in that polling sttion are still available. Since you are neutral at the input 'X', you should add it as one of the cases in the switch.

Your new while loop should look like:

Voters_Still_Present = 1;
while (Voters_Still_Present)
    {
        cout << "Vote for candidate A, B or C : " << endl;
        cin  >> vote;

        switch(vote)
        {
              case 'A':
                   votesForA++;
                   break;
              case 'B':
                   votesForB++;
                   break;
              case 'C':
                   votesForC++;
                   break;
              case 'X':
                   //do nothing
                   break;
              default:
                   spoiltVotes++;
        }  
       /* Here, find out if voters are still available in the present station.
          If yes, Voters_Still_Present = 1; else  Voters_Still_Present = 0;
        */            
    }

answered Mar 25, 2012 at 10:26

Tabrez Ahmed

3,0007 gold badges35 silver badges51 bronze badges

4 Comments

user1291092 Over a year ago

I need the program to run the loop 4 times and each time store the results and at the end of the fourth time is will then display the totals of each candidate. Thanks

user1291092 Over a year ago

Goodday Ahmed, I have declared Voters_Still_Present as an int created a if statement. I am new at this so please excuse me. if (Voters_Still_Present = 1) { cout << ""; } else { Voters_Still_Present = 0; }

Tabrez Ahmed Over a year ago

Please join the chatroom chat.stackoverflow.com/rooms/9327/c. we could discuss the question further.

user1291092 Over a year ago

Hi Ahmed, I am in the chatroom now

Collectives™ on Stack Overflow

For loop not working correctly

5 Answers 5

Comments

Comments

Comments

Comments

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

Comments

Comments

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related