diff options
| author | Cristian Maureira-Fredes <Cristian.Maureira-Fredes@qt.io> | 2021-05-12 14:51:00 +0200 |
|---|---|---|
| committer | Cristian Maureira-Fredes <Cristian.Maureira-Fredes@qt.io> | 2021-05-12 20:33:39 +0200 |
| commit | 06f6395b46492b2be45f9f06f9258f9b31b323e4 (patch) | |
| tree | 0833daaf85cd28b599269aecc3a22b8c48d69e1c /examples/widgets/graphicsview | |
| parent | c5db9d63277201ee58829f7eb0656c534d04c249 (diff) | |
examples: avoid built-in functions names as variable
There were many variable names using built-in python functions
so this patch renames them to something safe.
Task-number: PYSIDE-841
Change-Id: Iade34711ba31797f08f3f924be05023a7f12d5ef
Reviewed-by: Christian Tismer <tismer@stackless.com>
Diffstat (limited to 'examples/widgets/graphicsview')
| -rw-r--r-- | examples/widgets/graphicsview/diagramscene/diagramscene.py | 8 | ||||
| -rw-r--r-- | examples/widgets/graphicsview/elasticnodes/elasticnodes.py | 12 |
2 files changed, 10 insertions, 10 deletions
diff --git a/examples/widgets/graphicsview/diagramscene/diagramscene.py b/examples/widgets/graphicsview/diagramscene/diagramscene.py index bd3e4a4c3..7588c50a0 100644 --- a/examples/widgets/graphicsview/diagramscene/diagramscene.py +++ b/examples/widgets/graphicsview/diagramscene/diagramscene.py @@ -439,16 +439,16 @@ class MainWindow(QMainWindow): self.scene.update() self.view.update() - def button_group_clicked(self, id): + def button_group_clicked(self, idx): buttons = self._button_group.buttons() for button in buttons: - if self._button_group.button(id) != button: + if self._button_group.button(idx) != button: button.setChecked(False) - if id == self.insert_text_button: + if idx == self.insert_text_button: self.scene.set_mode(DiagramScene.InsertText) else: - self.scene.set_item_type(id) + self.scene.set_item_type(idx) self.scene.set_mode(DiagramScene.InsertItem) def delete_item(self): diff --git a/examples/widgets/graphicsview/elasticnodes/elasticnodes.py b/examples/widgets/graphicsview/elasticnodes/elasticnodes.py index 02a91a06d..78f006285 100644 --- a/examples/widgets/graphicsview/elasticnodes/elasticnodes.py +++ b/examples/widgets/graphicsview/elasticnodes/elasticnodes.py @@ -58,7 +58,7 @@ def random(boundary): class Edge(QGraphicsItem): - type = QGraphicsItem.UserType + 2 + item_type = QGraphicsItem.UserType + 2 def __init__(self, sourceNode, destNode): super().__init__() @@ -73,8 +73,8 @@ class Edge(QGraphicsItem): self.dest().add_edge(self) self.adjust() - def type(self): - return Edge.type + def item_type(self): + return Edge.item_type def source_node(self): return self.source() @@ -157,7 +157,7 @@ class Edge(QGraphicsItem): class Node(QGraphicsItem): - type = QGraphicsItem.UserType + 1 + item_type = QGraphicsItem.UserType + 1 def __init__(self, graphWidget): super().__init__() @@ -170,8 +170,8 @@ class Node(QGraphicsItem): self.setCacheMode(self.DeviceCoordinateCache) self.setZValue(-1) - def type(self): - return Node.type + def item_type(self): + return Node.item_type def add_edge(self, edge): self._edge_list.append(weakref.ref(edge)) |