diff options
| author | Christian Tismer <tismer@stackless.com> | 2020-02-13 13:35:03 +0100 |
|---|---|---|
| committer | Christian Tismer <tismer@stackless.com> | 2020-02-21 15:14:18 +0100 |
| commit | d579912b31d7cfa7b0b216916fbbf3eb632a9d9d (patch) | |
| tree | 0e206543adc1781003c39bdf8627af09cbe9270f /sources/pyside2/tests/QtWidgets/qapplication_singleton_test.py | |
| parent | f69d163d17d3717c28f2c065173113756d7c50ef (diff) | |
Turn qApp into a normal Python variable, finally
After a long odyssey of more or less unpythonic compromizes,
the qApp "macro" would finally be moved into a normal
variable without surprizes.
This was only possible since we removed qApp from QtWidgets
and other modules. Otherwise,
from PySide2.QtWidgets import *
would pull qApp, being the constant "None", into main and
shadow the true qApp variable in the builtins.
By inserting qApp into the builtins, only, we make sure that
this variable is always freshly looked up, without making it
change its contents.
DONE...
+ change the singleton code to normal
+ rename to MakeQAppWrapper
+ simplify the implementation
+ fix new bug concerning duplicate applications
+ check very much for refcounting bugs
+ review the rest of the implementation and further simplify
Note... The Q*Application variable will not be turned back into
a GC variable. This is not worth the effort.
Fixes: PYSIDE-571
Change-Id: Idbd158c083318e6b0dfe48d62485c68c90e944de
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
Diffstat (limited to 'sources/pyside2/tests/QtWidgets/qapplication_singleton_test.py')
| -rw-r--r-- | sources/pyside2/tests/QtWidgets/qapplication_singleton_test.py | 39 |
1 files changed, 0 insertions, 39 deletions
diff --git a/sources/pyside2/tests/QtWidgets/qapplication_singleton_test.py b/sources/pyside2/tests/QtWidgets/qapplication_singleton_test.py deleted file mode 100644 index e79e303f0..000000000 --- a/sources/pyside2/tests/QtWidgets/qapplication_singleton_test.py +++ /dev/null @@ -1,39 +0,0 @@ -############################################################################# -## -## Copyright (C) 2016 The Qt Company Ltd. -## Contact: https://www.qt.io/licensing/ -## -## This file is part of the test suite of Qt for Python. -## -## $QT_BEGIN_LICENSE:GPL-EXCEPT$ -## Commercial License Usage -## Licensees holding valid commercial Qt licenses may use this file in -## accordance with the commercial license agreement provided with the -## Software or, alternatively, in accordance with the terms contained in -## a written agreement between you and The Qt Company. For licensing terms -## and conditions see https://www.qt.io/terms-conditions. For further -## information use the contact form at https://www.qt.io/contact-us. -## -## GNU General Public License Usage -## Alternatively, this file may be used under the terms of the GNU -## General Public License version 3 as published by the Free Software -## Foundation with exceptions as appearing in the file LICENSE.GPL3-EXCEPT -## included in the packaging of this file. Please review the following -## information to ensure the GNU General Public License requirements will -## be met: https://www.gnu.org/licenses/gpl-3.0.html. -## -## $QT_END_LICENSE$ -## -############################################################################# - -import unittest - -from PySide2.QtWidgets import QApplication - -class TestSingleton(unittest.TestCase): - def testBasic(self): - a = QApplication([]) - self.assertRaises(RuntimeError, QApplication, []) - -if __name__ == '__main__': - unittest.main() |