diff options
| author | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2024-06-18 11:27:06 +0200 |
|---|---|---|
| committer | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2024-06-24 10:36:11 +0200 |
| commit | 1a4593f940b0eca4d0756092ed34c2b6a6962bd6 (patch) | |
| tree | 2869c01e31258c12347601980715888e8b352a15 /sources/pyside6/libpyside/pysidemetafunction.cpp | |
| parent | 8f85650fe8066c5903e865aedb3d92d863243996 (diff) | |
libpyside: Fix static analysis warnings
- Initialize variables
- Use auto *
- Remove repeated return types
- Fix else after return
- Fix some invocations of static methods
- Make functions const/static where appropriate
- Fix some int types to avoid lossy conversions
- Use Py_RETURN_NONE where appropriate
- Minor cleanups
- Remove some macros
Change-Id: I7fa7a29e7b3dc47037027978001824e0709d001f
Reviewed-by: Shyamnath Premnadh <Shyamnath.Premnadh@qt.io>
Diffstat (limited to 'sources/pyside6/libpyside/pysidemetafunction.cpp')
| -rw-r--r-- | sources/pyside6/libpyside/pysidemetafunction.cpp | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/sources/pyside6/libpyside/pysidemetafunction.cpp b/sources/pyside6/libpyside/pysidemetafunction.cpp index e8173b97d..10ba894a7 100644 --- a/sources/pyside6/libpyside/pysidemetafunction.cpp +++ b/sources/pyside6/libpyside/pysidemetafunction.cpp @@ -51,15 +51,15 @@ PyTypeObject *PySideMetaFunction_TypeF(void) void functionFree(void *self) { - PySideMetaFunction *function = reinterpret_cast<PySideMetaFunction *>(self); + auto *function = reinterpret_cast<PySideMetaFunction *>(self); delete function->d; } PyObject *functionCall(PyObject *self, PyObject *args, PyObject * /* kw */) { - PySideMetaFunction *function = reinterpret_cast<PySideMetaFunction *>(self); + auto *function = reinterpret_cast<PySideMetaFunction *>(self); - PyObject *retVal; + PyObject *retVal{}; if (!PySide::MetaFunction::call(function->d->qobject, function->d->methodIndex, args, &retVal)) return nullptr; return retVal; @@ -123,12 +123,12 @@ bool call(QObject *self, int methodIndex, PyObject *args, PyObject **retVal) return false; } - QVariant *methValues = new QVariant[numArgs]; + auto *methValues = new QVariant[numArgs]; void **methArgs = new void *[numArgs]; // Prepare room for return type const char *returnType = method.typeName(); - if (returnType && std::strcmp("void", returnType)) + if (returnType && std::strcmp("void", returnType) != 0) argTypes.prepend(returnType); else argTypes.prepend(QByteArray()); |