diff options
| author | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2024-06-18 11:27:06 +0200 |
|---|---|---|
| committer | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2024-06-24 10:36:11 +0200 |
| commit | 1a4593f940b0eca4d0756092ed34c2b6a6962bd6 (patch) | |
| tree | 2869c01e31258c12347601980715888e8b352a15 /sources/pyside6/libpyside/pysideqenum.cpp | |
| parent | 8f85650fe8066c5903e865aedb3d92d863243996 (diff) | |
libpyside: Fix static analysis warnings
- Initialize variables
- Use auto *
- Remove repeated return types
- Fix else after return
- Fix some invocations of static methods
- Make functions const/static where appropriate
- Fix some int types to avoid lossy conversions
- Use Py_RETURN_NONE where appropriate
- Minor cleanups
- Remove some macros
Change-Id: I7fa7a29e7b3dc47037027978001824e0709d001f
Reviewed-by: Shyamnath Premnadh <Shyamnath.Premnadh@qt.io>
Diffstat (limited to 'sources/pyside6/libpyside/pysideqenum.cpp')
| -rw-r--r-- | sources/pyside6/libpyside/pysideqenum.cpp | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/sources/pyside6/libpyside/pysideqenum.cpp b/sources/pyside6/libpyside/pysideqenum.cpp index c0479160f..897c9f4d0 100644 --- a/sources/pyside6/libpyside/pysideqenum.cpp +++ b/sources/pyside6/libpyside/pysideqenum.cpp @@ -75,7 +75,7 @@ static PyObject *analyzePyEnum(PyObject *pyenum) static Py_ssize_t get_lineno() { - PyObject *frame = reinterpret_cast<PyObject *>(PyEval_GetFrame()); // borrowed ref + auto *frame = reinterpret_cast<PyObject *>(PyEval_GetFrame()); // borrowed ref AutoDecRef ob_lineno(PyObject_GetAttr(frame, Shiboken::PyName::f_lineno())); if (ob_lineno.isNull() || !PyLong_Check(ob_lineno)) return -1; @@ -84,7 +84,7 @@ static Py_ssize_t get_lineno() static bool is_module_code() { - PyObject *frame = reinterpret_cast<PyObject *>(PyEval_GetFrame()); // borrowed ref + auto *frame = reinterpret_cast<PyObject *>(PyEval_GetFrame()); // borrowed ref AutoDecRef ob_code(PyObject_GetAttr(frame, Shiboken::PyName::f_code())); if (ob_code.isNull()) return false; @@ -133,14 +133,14 @@ PyObject *QEnumMacro(PyObject *pyenum, bool flag) return nullptr; if (bool(computedFlag) != flag) { AutoDecRef name(PyObject_GetAttr(pyenum, PyMagicName::qualname())); - auto cname = String::toCString(name); + const auto *cname = String::toCString(name); const char *e = "Enum"; const char *f = "Flag"; PyErr_Format(PyExc_TypeError, "expected '%s' but got '%s' (%.200s)", flag ? f : e, flag ? e : f, cname); return nullptr; } - auto ok = analyzePyEnum(pyenum); + auto *ok = analyzePyEnum(pyenum); if (ok == nullptr) return nullptr; if (is_module_code()) { @@ -169,7 +169,7 @@ std::vector<PyObject *> resolveDelayedQEnums(PyTypeObject *containerType) */ if (enumCollector.empty()) return {}; - PyObject *obContainerType = reinterpret_cast<PyObject *>(containerType); + auto *obContainerType = reinterpret_cast<PyObject *>(containerType); Py_ssize_t lineno = get_lineno(); std::vector<PyObject *> result; |