diff options
| author | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2023-09-18 09:55:49 +0200 |
|---|---|---|
| committer | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2023-09-20 13:44:47 +0200 |
| commit | 2cc7ded80caa506263ba2c9fd87db76dae71956a (patch) | |
| tree | 353da05cded3d6ca9dd0efa5d4cb4a34e0dc57bf /sources/pyside6/libpyside/signalmanager.cpp | |
| parent | c47bc0eea7348020d748f67555f60542ff496c0a (diff) | |
Fix namespaces
- Use nested namespaces instead repetitive namespace declaration
- Remove anonymous namespaces that contain only static functions.
"static" is sufficient here, the anonymous namespace only increases
compilation time.
Pick-to: 6.6 6.5
Change-Id: I6cd1b63da79eaf40a1b7ae031def97fa22903e99
Reviewed-by: Shyamnath Premnadh <Shyamnath.Premnadh@qt.io>
Diffstat (limited to 'sources/pyside6/libpyside/signalmanager.cpp')
| -rw-r--r-- | sources/pyside6/libpyside/signalmanager.cpp | 30 |
1 files changed, 11 insertions, 19 deletions
diff --git a/sources/pyside6/libpyside/signalmanager.cpp b/sources/pyside6/libpyside/signalmanager.cpp index a5afdd13e..96567901c 100644 --- a/sources/pyside6/libpyside/signalmanager.cpp +++ b/sources/pyside6/libpyside/signalmanager.cpp @@ -37,21 +37,17 @@ #define PYSIDE_SIGNAL '2' #include "globalreceiverv2.h" -namespace { - static PyObject *metaObjectAttr = nullptr; - - static PyObject *parseArguments(const QList< QByteArray >& paramTypes, void **args); - static bool emitShortCircuitSignal(QObject *source, int signalIndex, PyObject *args); - - static void destroyMetaObject(PyObject *obj) - { - void *ptr = PyCapsule_GetPointer(obj, nullptr); - auto meta = reinterpret_cast<PySide::MetaObjectBuilder *>(ptr); - SbkObject *wrapper = Shiboken::BindingManager::instance().retrieveWrapper(meta); - if (wrapper) - Shiboken::BindingManager::instance().releaseWrapper(wrapper); - delete meta; - } +static PyObject *metaObjectAttr = nullptr; +static PyObject *parseArguments(const QList< QByteArray >& paramTypes, void **args); +static bool emitShortCircuitSignal(QObject *source, int signalIndex, PyObject *args); +static void destroyMetaObject(PyObject *obj) +{ + void *ptr = PyCapsule_GetPointer(obj, nullptr); + auto meta = reinterpret_cast<PySide::MetaObjectBuilder *>(ptr); + SbkObject *wrapper = Shiboken::BindingManager::instance().retrieveWrapper(meta); + if (wrapper) + Shiboken::BindingManager::instance().releaseWrapper(wrapper); + delete meta; } static const char *metaCallName(QMetaObject::Call call) @@ -707,8 +703,6 @@ const QMetaObject *SignalManager::retrieveMetaObject(PyObject *self) return builder->update(); } -namespace { - static PyObject *parseArguments(const QList<QByteArray>& paramTypes, void **args) { const qsizetype argsSize = paramTypes.size(); @@ -735,5 +729,3 @@ static bool emitShortCircuitSignal(QObject *source, int signalIndex, PyObject *a source->qt_metacall(QMetaObject::InvokeMetaMethod, signalIndex, signalArgs); return true; } - -} //namespace |