diff options
| author | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2023-10-13 11:28:36 +0200 |
|---|---|---|
| committer | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2023-10-17 19:08:18 +0200 |
| commit | 9e2ac0478db3ed4e33119f2128a9053a852f2fac (patch) | |
| tree | 69da3b663ca62d57743f4fd374071e85eca4f0aa /sources/pyside6/libpyside | |
| parent | b21d14efdfa6730ed408e6e680e83185d62d631f (diff) | |
Improve error messages around signal/slot connections
Task-number: PYSIDE-2487
Pick-to: 6.6 6.5
Change-Id: I93d2c350aecf1339c6b18496f376d04cdd37dc29
Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
Diffstat (limited to 'sources/pyside6/libpyside')
| -rw-r--r-- | sources/pyside6/libpyside/pysidesignal.cpp | 4 | ||||
| -rw-r--r-- | sources/pyside6/libpyside/signalmanager.cpp | 8 |
2 files changed, 7 insertions, 5 deletions
diff --git a/sources/pyside6/libpyside/pysidesignal.cpp b/sources/pyside6/libpyside/pysidesignal.cpp index af544c4f7..9dfa04e1a 100644 --- a/sources/pyside6/libpyside/pysidesignal.cpp +++ b/sources/pyside6/libpyside/pysidesignal.cpp @@ -694,8 +694,8 @@ static PyObject *signalInstanceDisconnect(PyObject *self, PyObject *args) Py_DECREF(result); } - PyErr_Format(PyExc_RuntimeError, "Failed to disconnect signal %s.", - source->d->signature.constData()); + PyErr_Format(PyExc_RuntimeError, "Failed to disconnect (%S) from signal \"%s\".", + slot, source->d->signature.constData()); return nullptr; } diff --git a/sources/pyside6/libpyside/signalmanager.cpp b/sources/pyside6/libpyside/signalmanager.cpp index 4ed39dd5a..b4e1bb487 100644 --- a/sources/pyside6/libpyside/signalmanager.cpp +++ b/sources/pyside6/libpyside/signalmanager.cpp @@ -658,7 +658,9 @@ int SignalManager::registerMetaMethodGetIndex(QObject *source, const char *signa if (methodIndex == -1) { SbkObject *self = Shiboken::BindingManager::instance().retrieveWrapper(source); if (!Shiboken::Object::hasCppWrapper(self)) { - qWarning() << "Invalid Signal signature:" << signature; + qWarning().noquote().nospace() << __FUNCTION__ + << ": Cannot add dynamic method \"" << signature << "\" (" << type + << ") to " << source << ": No Wrapper found."; return -1; } auto *pySelf = reinterpret_cast<PyObject *>(self); @@ -676,8 +678,8 @@ int SignalManager::registerMetaMethodGetIndex(QObject *source, const char *signa if (type == QMetaMethod::Slot) { qCWarning(lcPySide).noquote().nospace() << "Warning: Registering dynamic slot \"" - << signature << "\" on " << source->metaObject()->className() - << ". Consider annotating with " << slotSignature(signature); + << signature << "\" on \"" << source->metaObject()->className() + << "\". Consider annotating with " << slotSignature(signature); } return type == QMetaMethod::Signal |