diff options
| author | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2021-09-02 22:36:29 +0200 |
|---|---|---|
| committer | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2021-09-06 11:28:41 +0200 |
| commit | 6bddba36e03212a4a7d522938152519dfeec96c2 (patch) | |
| tree | edb666f70f775a96670d9e11045f6ff65feacabd /sources/shiboken6/ApiExtractor/clangparser/clangbuilder.cpp | |
| parent | 5e4a1287c1742f96c5ba3ce0aca75791ce806157 (diff) | |
shiboken6: Fix wrong replacement of Python argument placeholders
In ShibokenGenerator::writeCodeSnips(), when replacing the %1, %2..
placeholders, the function retrieved all overloads just to check
whether a single pyArg or a list (METH_VARARGS) was used. Since it
checked only on the implementing class, it did not detect overloads
from base classes. Pass the usesPyArgs variable from function
writeMethodCall, where it is correctly determined.
Move pythonFunctionWrapperUsesListOfArguments() from
ShibokenGenerator to OverloadData.
A similar problem existed in
CppGenerator::writeParentChildManagement().
Manifested when generating QObject::disconnect(*) overloads
in addition to QCoapClient::disconnect().
It also is the underlying issue of the warning:
qt.shiboken: (help) Wrong index for %PYARG variable (3) on QHelpIndexModel::createIndex(int row, int column, PyObject * ptr) const
Change-Id: Ie676e53d72332714b7b410ef625160ea90ae4313
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
Diffstat (limited to 'sources/shiboken6/ApiExtractor/clangparser/clangbuilder.cpp')
0 files changed, 0 insertions, 0 deletions
