diff options
| author | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2023-09-25 16:15:25 +0200 |
|---|---|---|
| committer | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2023-09-27 11:13:31 +0200 |
| commit | d88eba7e8f8f9951e48709a1503931025a592d6a (patch) | |
| tree | b3466d2f03e44b19cc7e1d2748ed1fb791235dfb /sources/shiboken6/tests/libsample/str.cpp | |
| parent | f6d11df9409da11e084f57633025c2806735e8b7 (diff) | |
Fix some static analysis warnings in the shiboken tests
- else after return
- Do not repeat return types
- Use range-based for for std::map
- Use constructor member initialization
- Initialize variables
- Use override instead of repeating virtual
- Use noexcept for move special functions
- Upper case integer literals
- Various other small fixes
Pick-to: 6.6 6.5
Change-Id: I06924c60fcd0d8bfcad9cc2cd6e79e72621cb766
Reviewed-by: Shyamnath Premnadh <Shyamnath.Premnadh@qt.io>
Diffstat (limited to 'sources/shiboken6/tests/libsample/str.cpp')
| -rw-r--r-- | sources/shiboken6/tests/libsample/str.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/sources/shiboken6/tests/libsample/str.cpp b/sources/shiboken6/tests/libsample/str.cpp index 96fbba74a..742c0bb01 100644 --- a/sources/shiboken6/tests/libsample/str.cpp +++ b/sources/shiboken6/tests/libsample/str.cpp @@ -68,7 +68,7 @@ int Str::toInt(bool *ok, int base) const conv >> std::hex >> result; break; } - const bool my_ok = std::istringstream::eofbit &conv.rdstate(); + const bool my_ok = std::istringstream::eofbit & conv.rdstate(); if (!my_ok) result = 0; if (ok) @@ -120,7 +120,7 @@ unsigned int strHash(const Str &str) { unsigned int result = 0; for (char c : str.m_str) - result = 5u * result + unsigned(c); + result = 5U * result + unsigned(c); return result; } |