diff options
| author | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2023-09-25 16:15:25 +0200 |
|---|---|---|
| committer | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2023-09-27 11:13:31 +0200 |
| commit | d88eba7e8f8f9951e48709a1503931025a592d6a (patch) | |
| tree | b3466d2f03e44b19cc7e1d2748ed1fb791235dfb /sources/shiboken6/tests/libsample/transform.cpp | |
| parent | f6d11df9409da11e084f57633025c2806735e8b7 (diff) | |
Fix some static analysis warnings in the shiboken tests
- else after return
- Do not repeat return types
- Use range-based for for std::map
- Use constructor member initialization
- Initialize variables
- Use override instead of repeating virtual
- Use noexcept for move special functions
- Upper case integer literals
- Various other small fixes
Pick-to: 6.6 6.5
Change-Id: I06924c60fcd0d8bfcad9cc2cd6e79e72621cb766
Reviewed-by: Shyamnath Premnadh <Shyamnath.Premnadh@qt.io>
Diffstat (limited to 'sources/shiboken6/tests/libsample/transform.cpp')
| -rw-r--r-- | sources/shiboken6/tests/libsample/transform.cpp | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/sources/shiboken6/tests/libsample/transform.cpp b/sources/shiboken6/tests/libsample/transform.cpp index ebcab630a..5ccf5d1ed 100644 --- a/sources/shiboken6/tests/libsample/transform.cpp +++ b/sources/shiboken6/tests/libsample/transform.cpp @@ -19,10 +19,10 @@ Point applyHomogeneousTransform(const Point &in, if (std::isfinite(w) && fabs(w) > 1e-10) { if (okay) *okay = true; - return Point(x / w, y / w); - } else { - if (okay) - *okay = false; - return Point(); + return {x / w, y / w}; } + + if (okay) + *okay = false; + return {}; } |