diff options
| author | Giuseppe D'Angelo <giuseppe.dangelo@kdab.com> | 2025-03-25 11:58:36 +0100 |
|---|---|---|
| committer | Giuseppe D'Angelo <giuseppe.dangelo@kdab.com> | 2025-04-24 10:44:03 +0100 |
| commit | eeead68995653ab38e43e9f1494feaaa679dfd07 (patch) | |
| tree | d27faff34eee926996cabab0d2fafee17c00745d /examples/corelib | |
| parent | 323f408be6bcf5bfa5e2d447be94381556e52a62 (diff) | |
Examples: fix a couple of nodiscard warnings from QFile::open
In one case, the code simply checked for isOpen afterwards; refactor
it to use QFile::open's result. In another case, a file was opened
from the resource system, so add a check.
Pick-to: 6.9 6.8
Change-Id: I5f4c22dd5ce678f15c9c1609c4228d50a2b32a1d
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Diffstat (limited to 'examples/corelib')
| -rw-r--r-- | examples/corelib/serialization/convert/main.cpp | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/examples/corelib/serialization/convert/main.cpp b/examples/corelib/serialization/convert/main.cpp index d3021fadca2..aae20eb4a9a 100644 --- a/examples/corelib/serialization/convert/main.cpp +++ b/examples/corelib/serialization/convert/main.cpp @@ -23,12 +23,14 @@ static const Converter *prepareConverter(QString format, Converter::Direction di : QIODevice::ReadOnly; const char *dirn = out ? "output" : "input"; + bool isOpen; + if (stream->fileName().isEmpty()) - stream->open(out ? stdout : stdin, mode); + isOpen = stream->open(out ? stdout : stdin, mode); else - stream->open(mode); + isOpen = stream->open(mode); - if (!stream->isOpen()) { + if (!isOpen) { qFatal("Could not open \"%s\" for %s: %s", qPrintable(stream->fileName()), dirn, qPrintable(stream->errorString())); } else if (format == "auto"_L1) { |