diff options
| author | Johan Klokkhammer Helsing <johan.helsing@qt.io> | 2019-10-11 09:34:48 +0200 |
|---|---|---|
| committer | Johan Klokkhammer Helsing <johan.helsing@qt.io> | 2019-10-14 08:39:31 +0200 |
| commit | df91ff555178dd961e27ae11c4cb71811c9308a4 (patch) | |
| tree | f25bc9bae3e80a6d737fc4c89979a114a348df74 /examples/opengl/qopenglwidget/glwidget.cpp | |
| parent | d0b83adfe7b1d31db2e3febdd2638da0b1a13a0c (diff) | |
tst_qgraphicsitem: Don't assume window activation is available
Some windowing systems (i.e. Wayland) do not allow applications to steal window
focus.
Normally, we would just replace qWaitForWindowActive with
qWaitForWindowExposed, because that is usually the intent, in this test
however, there are many occurrences of both variants right after each other.
And, as described in the commit message of 153e8b49a, this may be because
window activation may cause repaints, and we want to wait for it to reduce
the chance of receiving an extra repaint later (possibly causing tests to be
racy).
Therefore, I took the conservative approach, and kept the qWaitForWindowActive
calls, except when the capability is not available. Hopefully this will not
cause flakiness in existing platforms, while also allowing tests to pass on
platforms where activation is not supported.
Task-number: QTBUG-62188
Change-Id: I15502baa28c464a808d585a5e6d67c9b745b17ae
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
Diffstat (limited to 'examples/opengl/qopenglwidget/glwidget.cpp')
0 files changed, 0 insertions, 0 deletions