The local appDir variable was only used to hold the return value of another function call. But hardly any compiler will be able to look through the QString atomic ref-counting to turn the non-Darwin code paths into the tail-calls that they ought to be. Remove the variable and return the result immediately. This removes the move-assignment and dtor calls in the two changed lines and lets RVO kick in, turning these calls into tail-calls on non-Darwin platforms. Amends 4ac872639ed0dd3ae6627e05bdda821f7d128500. Pick-to: 6.9 6.8 6.5 Change-Id: Ieeefbd52fc983ab7aebcff6419965b206f374935 Reviewed-by: Thiago Macieira <thiago.macieira@intel.com> Reviewed-by: Ahmad Samir <a.samirh78@gmail.com>