diff options
| author | Marc Mutz <marc.mutz@qt.io> | 2022-02-18 18:13:08 +0100 |
|---|---|---|
| committer | Marc Mutz <marc.mutz@qt.io> | 2022-02-20 01:06:29 +0000 |
| commit | d1c1b30f20b7381187b2b35a861b8ea258fc4ab3 (patch) | |
| tree | 12fbee4f63c281869e8e72a31f362c3a448356f8 /qmake/generators/unix/unixmake2.cpp | |
| parent | 2edae10fb480d63e29d768f7ec1966be983c2b75 (diff) | |
QStringConverter: make name matching locale-independent
The existing name lookup code used C's toupper() function for
case-insensitive comparison. However, that function's result depends
on the current locale.
Since the matcher is supposed to match the likes of "iso-8859-1" and
"latin-1", matching may fail in locales, such as Turkish, where
toupper(i) is İ (or i, if the former isn't representable in the current
charset), but toupper(I) remains I, causing a False Negative.
To fix, use the US-ASCII-only QtMiscUtils::toAsciiLower() function,
which has the added advantage that it's inline.
Pick-to: 6.3 6.2
Change-Id: I70613c0167d84e3dc3d282c61c716b5dd0b3e6bb
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Diffstat (limited to 'qmake/generators/unix/unixmake2.cpp')
0 files changed, 0 insertions, 0 deletions