diff options
| author | Thiago Macieira <thiago.macieira@intel.com> | 2016-06-02 10:46:36 -0300 |
|---|---|---|
| committer | Tony Sarajärvi <tony.sarajarvi@qt.io> | 2016-06-06 11:39:53 +0000 |
| commit | f8b5142e3068d210393e7e4544c2e63577a313ac (patch) | |
| tree | 6f4c10a70c4b953ecf6ab29584adaad188f614fa /src/concurrent/qtconcurrentiteratekernel.cpp | |
| parent | d5ac97e36fb35761576f25c84372d5c477189a0f (diff) | |
Fix race condition in tst_QDBusConnection::pendingCallWhenDisconnected
The test sent a message and hoped that the "delete server" would cause
the server object in the QDBusConnectionManager thread be deleted before
it could receive and process the message. That's racy, because on some
CI machines, it did and then sent back an error reply indicating the
object sought was not found.
Instead, let's use a child process that we can kill to make it exit at
the right time.
I've chosen to use dbus-daemon itself, because that lets us test the
actual conditions that triggered the original bug: the daemon getting
killed during a desktop session shutdown on Linux.
Change-Id: I87e17314d8b24ae983b1fffd1454483aea87c921
Reviewed-by: Tony Sarajärvi <tony.sarajarvi@qt.io>
Diffstat (limited to 'src/concurrent/qtconcurrentiteratekernel.cpp')
0 files changed, 0 insertions, 0 deletions