diff options
| author | Marc Mutz <marc.mutz@qt.io> | 2024-12-11 15:47:22 +0100 |
|---|---|---|
| committer | Marc Mutz <marc.mutz@qt.io> | 2024-12-12 21:06:59 +0100 |
| commit | a38cebfe23674bb459eed6bbbcac965ebf2b6075 (patch) | |
| tree | 2ba9bb4655586fd0cf1d5bc3c9722dc7c9c84cb8 /src/corelib/debug_script.py | |
| parent | 057defe283f1db5fa9dfb1d8183b94d441c3707b (diff) | |
qsocketnotifier.cpp: un-break -unity-build
qsocketnotifier.cpp is using a #define to activate a second overload
of QSocketNotifier's activated() signal.
In unity-builds, this overload becomes visible to other TUs and breaks
new-style connect()s¹. In PCH builds, the define comes too late (the
qsocketnotifier.h header was already included by the pch header,
without the define).
Fix by adding qsocketnotifier.cpp to NO_PCH_SOURCES (thereby to
NO_UNITY_BUILD_SOURCES, too).
¹ and the signal's use of QPrivateSignal makes disambiguation by
qOverload(), or assignment to a function pointer, impossible.
Amends 487dd80bce9c6006f349ccb09222e1c308200f0a(!).
Pick-to: 6.9 6.8 6.5 5.15
Change-Id: I40ca3b90f7ecc3116ae78dc952583efa299bcedb
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
Diffstat (limited to 'src/corelib/debug_script.py')
0 files changed, 0 insertions, 0 deletions
