This is more robust and lessens the impedance mismatch as seen by the old code using std::unique_ptr<char[]>(expr).get(). The new code isn't impedance-mismatch-free, either (UP{qstrdup(qba.data())}), but short of writing a small string class whose internal buffer can be release()ed to comply with the archaic QTest::toString() new[]'ed const char* return value, there's not much we can do about it atm. Also separate the internal from the "public" stuff in QCborValueFormatter by adding private: and public: sections. Pick-to: 6.9 6.8 Change-Id: I09a2ad1a75bb9eab3d01f2b5b60afc2d762da384 Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>