diff options
| author | Ahmad Samir <a.samirh78@gmail.com> | 2024-09-11 17:03:28 +0300 |
|---|---|---|
| committer | Ahmad Samir <a.samirh78@gmail.com> | 2024-09-20 22:59:39 +0300 |
| commit | 4fecfcc867f8215defaa40b50f0340654a36b4c7 (patch) | |
| tree | a2d782d102c87f7aef7ab71b25f9bb1f31d65eab /src/corelib/io/qfsfileengine.cpp | |
| parent | c5933597ad74ff3206075a1814ed9111ea55f9b6 (diff) | |
QAbstractFileEngine: remove beginEntryList(QDir::Filters)
It was kept so as not to break compilation of user code (overriding a
function that doesn't exist in the base class). But as Marcus Tillmanns
pointed out in a qtcreator code review, it can't work because
QDirListing calls the virutal
engine->beginEntryList(QDirListing::IteratorFlags).
Removing beginEntryList(QDir::Filters) and getting a compile-timer error
is better than the code failing silently in user code (all sub-classes
of QAbstractFileEngine in qtbase have been already ported).
QDir::entryList() isn't affected because it calls
QAbstractFileEngine::entryList() which has an overload that works with
QDir::Filters.
Pick-to: 6.8
Change-Id: I3cb18402f602ac78a6b29be57e59febb2b9db7c0
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Diffstat (limited to 'src/corelib/io/qfsfileengine.cpp')
| -rw-r--r-- | src/corelib/io/qfsfileengine.cpp | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/src/corelib/io/qfsfileengine.cpp b/src/corelib/io/qfsfileengine.cpp index 6610b6ecd66..a71b6f8e1e3 100644 --- a/src/corelib/io/qfsfileengine.cpp +++ b/src/corelib/io/qfsfileengine.cpp @@ -793,13 +793,6 @@ qint64 QFSFileEnginePrivate::writeFdFh(const char *data, qint64 len) \internal */ QAbstractFileEngine::IteratorUniquePtr -QFSFileEngine::beginEntryList(const QString &path, QDir::Filters filters, - const QStringList &filterNames) -{ - return std::make_unique<QFSFileEngineIterator>(path, filters, filterNames); -} - -QAbstractFileEngine::IteratorUniquePtr QFSFileEngine::beginEntryList(const QString &path, QDirListing::IteratorFlags filters, const QStringList &filterNames) { |