diff options
| author | Marc Mutz <marc.mutz@qt.io> | 2025-09-29 11:32:59 +0200 |
|---|---|---|
| committer | Marc Mutz <marc.mutz@qt.io> | 2025-09-30 20:56:48 +0200 |
| commit | 6b494c507d51b2b24cb48578216cf4e200a6e7d8 (patch) | |
| tree | b34369d0de4feaf73cfba70ddcd4307039bce830 /src/corelib/kernel/qobject.cpp | |
| parent | 7ca5a18b045b82ab9b369b5caa80065fe1a43c09 (diff) | |
Mark QVariant as security-critical
If QVariant was just a container (open sum type, like std::any), the
story would end there, and it could be marked as security-significant,
the default, like QList. Both are used all over the place in Qt, but,
crucially, QList doesn't interpret its contents. QString does, so it's
security-critical.
Unfortunately, QVariant also interprets its contents (it performs
conversion between content types), and there's also
load(QDataStream&), so this can't be anything else but critical.
Both headers are full of implementation most of which can't be called
trivial, so the headers are critical, too.
Task-number: QTBUG-135190
Pick-to: 6.10 6.8
Change-Id: I12688f502b6362f2f541a5aba012c80677dbfef9
Reviewed-by: Matthias Rauter <matthias.rauter@qt.io>
Diffstat (limited to 'src/corelib/kernel/qobject.cpp')
0 files changed, 0 insertions, 0 deletions
