Coverity complains that we should have moved 'entry' into 'prefix'. Since there are another 60-70 LOC following in that scope, it would harm readabilty if we simply did that. We'd also need to make 'entry' non-const, futher complicating the function by turning a constant into yet another variable. Instead, move the definition of 'prefix' into the loop body as a local variable (capturing the result of QString::first(), saving a move-assignment as a drive-by). Since 'prefix' is now a loop-iteration-local variable, we can, at the end of the loop, move it into uiLanguages. _That_ move is ok, readability-wise, because it happens at the end of the scope. We can't keep iterating over prefix.lastIndexOf(), of course, so iterate over 'entry' instead. That means we need to remember the last separator's position, which isn't a problem, since there's already a variable for it. We just need to adjust its initial value and pass it as 'from' to lastIndexOf(). Note that this is safe even if entry.isEmpty() (which shouldn't happen, since empty string shouldn't be in uiLanguages). Amends 2c39365aad957aea7ca9c9c861665391edf7ef23. Coverity-Id: 474044 Pick-to: 6.10 6.9 Change-Id: I2d809dc5e4d5c014141805db31ea7f8f1dfa5010 Reviewed-by: Edward Welbourne <edward.welbourne@qt.io> Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>