diff options
| author | Marc Mutz <marc.mutz@qt.io> | 2023-08-10 16:03:46 +0200 |
|---|---|---|
| committer | Thiago Macieira <thiago.macieira@intel.com> | 2023-08-14 20:13:54 +0000 |
| commit | 9c1d20337a5585c620e13776f9c33582f2e479d8 (patch) | |
| tree | 8160d1f067aee186e97fdcc16a5638ee3ae26018 /src/corelib/plugin/quuid.cpp | |
| parent | 3693dd74febbd928eefa8291a05f6ef5a65ffe63 (diff) | |
Remove QUuid(quint128) constructor again
This constructor matches way too many argument types (integral,
unscoped enums, FP types), so it's likely to cause mayhem, even if
left in as an explicit constructor.
We now have a named constructor for the same functionality, so just
drop the "unnamed" constructor.
"Unnamed" constructors are important when emplacement is more
efficient than construction + move, or when implicit conversion is
required. Neither is the case here: The named as well as the
"unnamed" constructors just copy ten bytes around, and the compiler
can optimize those extra copies away just fine.
Found in API review.
Pick-to: 6.6
Change-Id: I7faafd3ebf522fb2b0e450112fb95d643fece5ce
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Ivan Solovev <ivan.solovev@qt.io>
Diffstat (limited to 'src/corelib/plugin/quuid.cpp')
| -rw-r--r-- | src/corelib/plugin/quuid.cpp | 13 |
1 files changed, 0 insertions, 13 deletions
diff --git a/src/corelib/plugin/quuid.cpp b/src/corelib/plugin/quuid.cpp index b446edbc958..2a2f4cb00d5 100644 --- a/src/corelib/plugin/quuid.cpp +++ b/src/corelib/plugin/quuid.cpp @@ -311,19 +311,6 @@ static QUuid createFromName(const QUuid &ns, const QByteArray &baseData, QCrypto */ /*! - \fn QUuid::QUuid(quint128 uuid, QSysInfo::Endian order) noexcept - \since 6.6 - - Creates a QUuid based on the integral \a uuid parameter and respecting the - byte order \a order. - - \note This function is only present on platforms that offer a 128-bit - integer type. - - \sa toUInt128(), fromUInt128(), fromBytes(), toBytes(), toRfc4122() -*/ - -/*! \fn QUuid::fromUInt128(quint128 uuid, QSysInfo::Endian order) noexcept \since 6.6 |