diff options
| author | Marc Mutz <marc.mutz@kdab.com> | 2016-10-08 16:41:46 +0200 |
|---|---|---|
| committer | Giuseppe D'Angelo <giuseppe.dangelo@kdab.com> | 2016-11-08 16:33:10 +0000 |
| commit | ef36fd02178482cd312ea551303856ef563421af (patch) | |
| tree | 2fff948eaab4b987856f39dd16f943797a46dd54 /src/gui/opengl/qopengl.h | |
| parent | e25f2392eb4a208449c3aa53196c81583dba08dc (diff) | |
QGraphicsSceneBspTreeIndex: fix misleading code in event()
The old code employed a switch statement to filter timer events,
but fell unconditionally through to the default case of calling
QObject::event(). The final return statement following the switch
is thus dead code.
Fix by turning the switch into an if and returning QObject::event()
unconditionally afterwards, which much better describes the intent
of the code, and also fixes the GCC 7 warning about implicit fall-
through in the switch (which wasn't implicit to a human, but GCC's
comment-reading-capabilities are somewhat limited at this point).
Change-Id: I6756a65b3679a446d09fd721dfd0adc24fdf7772
Reviewed-by: Sérgio Martins <sergio.martins@kdab.com>
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
Diffstat (limited to 'src/gui/opengl/qopengl.h')
0 files changed, 0 insertions, 0 deletions
