Assuming QString has seen a lot more effort put into this, simply copy the preamble of QString::replace(ptr, n, ptr, n, cs) over to the corresponding QByteArray::replace(view, view) function, so they behave the same. On reviewer request, change d.size == 0 to isEmpty(), in both functions' preambles. [ChangeLog][QtCore][Important Behavior Changes][QByteArray] replace() is now consistent with QString::replace() in its treatment of empty haystacks and needles. Fixes: QTBUG-134079 Change-Id: I2366febee7de4646d6b33c39d2338760b58f2ec4 Reviewed-by: Thiago Macieira <thiago.macieira@intel.com> Reviewed-by: Ahmad Samir <a.samirh78@gmail.com>