diff options
| author | Piotr Wierciński <piotr.wiercinski@qt.io> | 2024-09-16 12:38:37 +0200 |
|---|---|---|
| committer | Piotr Wierciński <piotr.wiercinski@qt.io> | 2024-09-16 21:20:42 +0000 |
| commit | 21be40019f8adedf1e592b9b8ba0d965b857eef3 (patch) | |
| tree | 59eb51d06933a2d80c1ea343419a36f86526d313 /src/network/access/qnetworkreplywasmimpl.cpp | |
| parent | fc5015877f2fbf81178b5eb0aefccab5ace0a35d (diff) | |
wasm: Fix integer overflow in FetchRequest
Remove code which is trying to unset flag that has never been set
before. Subtracting flag on unsigned int "attributes" can cause integer
overlow.
Fixes: QTBUG-128929
Pick-to: 6.5 6.7 6.8
Change-Id: I4128819f29a841b73b6a08aeba795dcae9dc2e51
Reviewed-by: Morten Johan Sørvig <morten.sorvig@qt.io>
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
Diffstat (limited to 'src/network/access/qnetworkreplywasmimpl.cpp')
| -rw-r--r-- | src/network/access/qnetworkreplywasmimpl.cpp | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/src/network/access/qnetworkreplywasmimpl.cpp b/src/network/access/qnetworkreplywasmimpl.cpp index 7f188bf7758..952c6f87586 100644 --- a/src/network/access/qnetworkreplywasmimpl.cpp +++ b/src/network/access/qnetworkreplywasmimpl.cpp @@ -263,11 +263,6 @@ void QNetworkReplyWasmImplPrivate::doSendRequest() attr.attributes += EMSCRIPTEN_FETCH_APPEND; } - if (CacheLoadControlAttribute == QNetworkRequest::AlwaysNetwork || - request.attribute(QNetworkRequest::CacheSaveControlAttribute, false).toBool()) { - attr.attributes -= EMSCRIPTEN_FETCH_PERSIST_FILE; - } - attr.withCredentials = request.attribute(QNetworkRequest::UseCredentialsAttribute, false).toBool(); attr.onsuccess = QNetworkReplyWasmImplPrivate::downloadSucceeded; attr.onerror = QNetworkReplyWasmImplPrivate::downloadFailed; |