diff options
| author | Marc Mutz <marc.mutz@qt.io> | 2025-04-06 14:32:07 +0200 |
|---|---|---|
| committer | Axel Spoerl <axel.spoerl@qt.io> | 2025-04-18 15:14:16 +0000 |
| commit | fb7670f193712fae2d4c03d6ee2a6c30101b886f (patch) | |
| tree | 9703b502a23af71329be4d98646dbd8ffc547175 /src/plugins/sqldrivers/mysql/qsql_mysql.cpp | |
| parent | 7ce4a8a8c977688144efb94d41e20ed2420aa74b (diff) | |
QMainWindowLayout: de-pessimize ~QMainWindowToolBar
As the code comment says, ~QMainWindowTabBar will removeOne(this) from
QMainWindowLayout::unusedTabBars. It doesn't assert that it was
included in it, or something special like that.
So we can optimize the whole thing by making sure that
~QMainWindowTabBar doesn't find anything to remove here, avoiding a
detach from the copy 'bars' and potentially also avoiding quadratic
behavior, as we delete the items in order.
Found by Coverity, but it only saw this as an optimization opportunity
because it doesn't understand that the copy is needed.
Amends 23357e59bb4dc54e76a237b290aa64a620db2ea1.
Pick-to: 6.9 6.8 6.5
Coverity-Id: 479705
Change-Id: I6c31e028c0c39813768e8c71076471b39bd8ef5a
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
Diffstat (limited to 'src/plugins/sqldrivers/mysql/qsql_mysql.cpp')
0 files changed, 0 insertions, 0 deletions