diff options
| author | Jędrzej Nowacki <jedrzej.nowacki@qt.io> | 2017-07-28 09:42:03 +0200 |
|---|---|---|
| committer | Simon Hausmann <simon.hausmann@qt.io> | 2017-07-29 09:35:16 +0000 |
| commit | 3760120ab33ea454bed320b10e8afcb29f7869ae (patch) | |
| tree | 52c13158db58a5e770679d1fd44adcba6e4fc1ea /src/plugins/sqldrivers/sqlite/qsql_sqlite.cpp | |
| parent | 5881fc0d2d58ae3e46c8fd3567c98ee689f5c900 (diff) | |
Remove tst_qtconcurrentiteratekernel blockSize test
The test is just wrong.
It suggests, that it tests minimal block size,
but in reality it is checking if a maximal peak of block size
is bigger then expected minimum block size.
The minimal block size is 1, not 1024 / ideal threads count and
it is defined in BlockSizeManagerV2.
The maximal block size is defined and it is fixed, but it is an
implementation detail, probably not worth testing.
The test is based on a race condition as peakBegin and
peakBlockSize are modified in parallel from multiple threads,
without any synchronization.
Change-Id: I430eedcf83b0fa3e2ce2cfd294eaee7b301e48ae
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
Diffstat (limited to 'src/plugins/sqldrivers/sqlite/qsql_sqlite.cpp')
0 files changed, 0 insertions, 0 deletions