diff options
| author | Marc Mutz <marc.mutz@kdab.com> | 2015-12-03 14:33:42 +0100 |
|---|---|---|
| committer | Marc Mutz <marc.mutz@kdab.com> | 2015-12-04 16:56:47 +0000 |
| commit | 909e6a009c968042f5295358737c9d2d84fcc0ba (patch) | |
| tree | 40900f5a8041809ec41e55acf46a8fdaeb7a8e39 /src/sql/drivers/mysql/qsql_mysql.cpp | |
| parent | 6b1dc2641e43f3e35ef91fb2d1301be236de9f95 (diff) | |
Clean up QGraphicsItemCache::purge()
The old code assigned an empty QPoint to elements contained
by value in a QHash that was cleared out in the very next
step.
That makes no sense, because the operations in the loop cannot
possibly cause a re-entrancy into QGraphicsItemCache, which
would be the only explanation for modifying the state of a
death-row object.
While at it, replace the use of the highly inefficient
(and no longer needed) QMutableHashIterator with C++11
range-for, taking care to iterate over a const reference to
avoid detaches.
Change-Id: Ie3eba0f954644a27932666bc9e97f1ca8f36a578
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@theqtcompany.com>
Diffstat (limited to 'src/sql/drivers/mysql/qsql_mysql.cpp')
0 files changed, 0 insertions, 0 deletions
