summaryrefslogtreecommitdiffstats
path: root/src/sql/drivers/sqlite/qsql_sqlite.cpp
diff options
context:
space:
mode:
authorMarc Mutz <marc.mutz@kdab.com>2015-07-25 12:24:20 +0200
committerMarc Mutz <marc.mutz@kdab.com>2016-02-17 16:17:37 +0000
commit773458ad633c68e9111888b71f8971064cf42fd3 (patch)
treeae20e1722c2ef193d08ab365b5efb4030913e173 /src/sql/drivers/sqlite/qsql_sqlite.cpp
parent30b0c346ec9bfe3730aa1a5a77199a3b0e61c1f8 (diff)
Remove QMimeMagicRule's pimpl
It didn't make the class implicitly shared, but required an additional heap allocation on construction and copy, as it used 'only' QScopedPointer. As it's private API the pimpl is also not needed for BC reasons. So inline the data members, and some trivial accessors. As a by-product of removing the copy special member functions, we gain nothrow move special member functions. Interestingly, the memory layout of a QList<QMimeMagicRule> (replacing which is the topic of a future patch) doesn't change due to this change, because the type that formerly fit QList very well now is too large. But copying the type outside QList now no longer allocates memory. Saves more than 2.5KiB in text size on optimized GCC 5.3 Linux AMD64 builds. Change-Id: Ie3588cb5693227da6f1bfa196db924e075a750b3 Reviewed-by: David Faure <david.faure@kdab.com>
Diffstat (limited to 'src/sql/drivers/sqlite/qsql_sqlite.cpp')
0 files changed, 0 insertions, 0 deletions