summaryrefslogtreecommitdiffstats
path: root/src/testlib/doc/snippets
diff options
context:
space:
mode:
authorAhmad Samir <a.samirh78@gmail.com>2023-03-05 00:13:32 +0200
committerAhmad Samir <a.samirh78@gmail.com>2023-06-30 02:24:53 +0300
commit57712e1160dd2bd37e8a0838cf0298b740a96983 (patch)
tree0d668885e8fbb4c8b9971d499e490bc48c90a2be /src/testlib/doc/snippets
parentc580a7b0fa09473fb6afaf3416c858b71171ad48 (diff)
QTest: add qWait(chrono::milliseconds) overload
The code bailed out of the while loop when "remainingTime <= 0", for a QDeadlineTimer::isForever() timer remainingTime() returns -1, whereas remainingTimeAsDuration() returns nanoseconds::max(). I.e. the original code stopped the while loop when the timer isForever() or "expired" (i.e. remaining time is 0). I am not sure the isForever() part was intended that way or not, but it makes sense, if QCoreApplication::processEvents() has already run "forever", there is no point looping again. [ChangeLog][QtCore][QTest] Added qWait(chrono::milliseconds) overload. Change-Id: I871c28b053c6ba4f81a7e2d434aa4fbe03c8c5e7 Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Diffstat (limited to 'src/testlib/doc/snippets')
-rw-r--r--src/testlib/doc/snippets/code/src_corelib_kernel_qtestsupport_core.cpp3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/testlib/doc/snippets/code/src_corelib_kernel_qtestsupport_core.cpp b/src/testlib/doc/snippets/code/src_corelib_kernel_qtestsupport_core.cpp
index 906a88b20f1..1bd6d3c0682 100644
--- a/src/testlib/doc/snippets/code/src_corelib_kernel_qtestsupport_core.cpp
+++ b/src/testlib/doc/snippets/code/src_corelib_kernel_qtestsupport_core.cpp
@@ -18,9 +18,10 @@ int myNetworkServerNotResponding()
int MyObject::isReady()
{
//! [1]
+ using namespace std::chrono_literals;
int i = 0;
while (myNetworkServerNotResponding() && i++ < 50)
- QTest::qWait(250);
+ QTest::qWait(250ms);
//! [1]
return 1;
}