diff options
| author | Rym Bouabid <rym.bouabid@qt.io> | 2024-08-13 12:42:01 +0200 |
|---|---|---|
| committer | Rym Bouabid <rym.bouabid@qt.io> | 2024-09-20 11:49:19 +0200 |
| commit | f0aa391ef89a393221d77d5ad3c1616a4727f11a (patch) | |
| tree | cf6b5a1b3d0a5644c1989ba0fc5ed26d093c0bd4 /src/tools/windeployqt/utils.cpp | |
| parent | 69e6ae1670faaa901e5ad06a79fa330761f1af36 (diff) | |
Use QIODevice::readLineInto() instead of readLine() in loops
Most of the callers of QIODevice::readLine() are reading a device line
by line in a loop. Instead, use one QByteArray and modify it in every
iteration using QIODevice::readLineInto().
Use a QByteArrayView instead of QByteArray when calling trimmed() as
it's an expensive operation.
Fixes: QTBUG-103108
Change-Id: Ic1af487a2fbf352cc21d76a41717944d034d3709
Reviewed-by: Marc Mutz <marc.mutz@qt.io>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Diffstat (limited to 'src/tools/windeployqt/utils.cpp')
| -rw-r--r-- | src/tools/windeployqt/utils.cpp | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/src/tools/windeployqt/utils.cpp b/src/tools/windeployqt/utils.cpp index 25b4a9788b2..ea32346c65f 100644 --- a/src/tools/windeployqt/utils.cpp +++ b/src/tools/windeployqt/utils.cpp @@ -225,10 +225,9 @@ QMap<QString, QString> queryQtPaths(const QString &qtpathsBinary, QString *error } QFile qconfigPriFile(result.value(QStringLiteral("QT_HOST_DATA")) + QStringLiteral("/mkspecs/qconfig.pri")); if (qconfigPriFile.open(QIODevice::ReadOnly | QIODevice::Text)) { - while (true) { - const QByteArray line = qconfigPriFile.readLine(); - if (line.isEmpty()) - break; + QByteArray lineArray; + while (qconfigPriFile.readLineInto(&lineArray)) { + QByteArrayView line = QByteArrayView(lineArray); if (line.startsWith("QT_LIBINFIX")) { const int pos = line.indexOf('='); if (pos >= 0) { |