The old code used QStringTokenizer to tokenize a string in a loop, but unconditionally exited the loop after the first iteration. There's a comment saying we're only interested in the first element, but I remember raising my eyebrows when I saw this code for the first time. Now I found that Coverity agrees and flags this as "structurally dead code". Fix by using indexOf() + truncate() on the string instead of tokenize() or (before 0108275b0c6a38ac73014c8e135b9be9fe75c8b2) split(). Since qEnvironmentVariable() returns an unshared QString, this is a cheap operation even on an owning container, so we don't need to use views. Amends 0108275b0c6a38ac73014c8e135b9be9fe75c8b2 for the Coverity warning, but the code before that was even worse: split().first(), so I'm going with amends 897e19f95ee91ec21bb9dd9f3157ee7333c9018f here. Coverity-Id: 444295 Pick-to: 6.10 6.9 6.8 6.5 Change-Id: I162bb58003eb18fa533199a6941455294f9d3b07 Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io> Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>