diff options
| author | Marc Mutz <marc.mutz@kdab.com> | 2017-02-07 10:44:55 +0100 |
|---|---|---|
| committer | Marc Mutz <marc.mutz@kdab.com> | 2017-02-07 12:01:08 +0000 |
| commit | 18e6e8105971df910ab3881ee36476432d17e382 (patch) | |
| tree | 3bea17baca93a8bea565f653e21f991bd1ded75e /tests/manual/windowflags/controllerwindow.cpp | |
| parent | ee348975654bb5f659370118dcf7b4bb494add87 (diff) | |
QCollator/ICU: fix a rather hair-raising performance bug in compare(QChar*, int, QChar*, int)
The intention when using an overload that takes (const QChar*, int)
instead of a QString is probably to avoid creating a QString in the
first place. If the implementation stabbs the user in the back by
internally creating a QString just so it can call QString::compare()
on it, then that is rather unacceptable.
QCollator is already a friend of QString, so, absent QStringView,
resolve to calling compare_helper().
Change-Id: Ia7de1a095e3e310bd1b9957ed67291cc9cc95b32
Reviewed-by: David Faure <david.faure@kdab.com>
Diffstat (limited to 'tests/manual/windowflags/controllerwindow.cpp')
0 files changed, 0 insertions, 0 deletions