diff options
| author | Laszlo Agocs <laszlo.agocs@qt.io> | 2022-10-17 17:13:32 +0200 |
|---|---|---|
| committer | Laszlo Agocs <laszlo.agocs@qt.io> | 2022-10-20 21:37:57 +0200 |
| commit | c79263f223c7f442a3e79e58d55164b472e210f0 (patch) | |
| tree | b7cc7d7ad045d11f9997a157d88f35a548732482 /src/qml/compiler/qv4codegen.cpp | |
| parent | 59d967a8fb60bb764654a857cac20196358865eb (diff) | |
Improve variable naming in QSGLayer implementation
'size' and 'rect' are names that should be avoided. In Qt 6 newer
code, such as QRhi, explicitly uses pixelSize instead of size, and
this is visible in some of the newer Qt Quick code as well, but old
code from Qt 5 times suffers from confusion still: even though on
the scenegraph level "everything" is in pixels, there are things
that aren't, for example the "rect" that gets passed to the
projection matrix calculation is in logical units! Comprehension
and maintenance gets challenged also when there are higher level
"size", "rect", "textureSize", etc. kind of names in QQuickItem
and elsewhere that are not necessarily in pixels yet can be
mistaken to map 1:1 to the scenegraph data.
Try to indicate this in argument and member names.
Also add a missing word to the QSGTexture docs. The overview
mentions this in fact but the function doc does not.
Task-number: QTBUG-107691
Change-Id: Idef7a83a2194ba5c0e3b12b1c0115b2b13fb7d66
Reviewed-by: Andy Nichols <andy.nichols@qt.io>
Diffstat (limited to 'src/qml/compiler/qv4codegen.cpp')
0 files changed, 0 insertions, 0 deletions
