diff options
| author | Lars Knoll <lars.knoll@qt.io> | 2018-02-10 19:17:40 +0100 |
|---|---|---|
| committer | Lars Knoll <lars.knoll@qt.io> | 2018-04-25 17:49:21 +0000 |
| commit | 31026b2e83ac338ebfb59ce0fede268e9ce51fed (patch) | |
| tree | 0a9bdf078db659cbed8c923bc04c8b6352bdf925 /src/qml/jsruntime/qv4functionobject.cpp | |
| parent | 219485d898556368a833576f1c55e210c1cf7189 (diff) | |
Correctly check for duplicate parameter names
Those are not allowed as soon as we have default values for parameters
or rest arguments.
Change-Id: I7dec826c37e6045e4dd1f6b0adb90301efe33daf
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
Diffstat (limited to 'src/qml/jsruntime/qv4functionobject.cpp')
| -rw-r--r-- | src/qml/jsruntime/qv4functionobject.cpp | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/qml/jsruntime/qv4functionobject.cpp b/src/qml/jsruntime/qv4functionobject.cpp index 73a8eb1193..390e0d5161 100644 --- a/src/qml/jsruntime/qv4functionobject.cpp +++ b/src/qml/jsruntime/qv4functionobject.cpp @@ -240,6 +240,9 @@ ReturnedValue FunctionCtor::callAsConstructor(const FunctionObject *f, const Val RuntimeCodegen cg(scope.engine, &jsGenerator, false); cg.generateFromFunctionExpression(QString(), function, fe, &module); + if (scope.hasException()) + return Encode::undefined(); + QQmlRefPointer<CompiledData::CompilationUnit> compilationUnit = cg.generateCompilationUnit(); Function *vmf = compilationUnit->linkToEngine(scope.engine); |