diff options
| author | Olaf Mandel <o.mandel@menlosystems.com> | 2023-06-16 13:34:17 +0200 |
|---|---|---|
| committer | Olaf Mandel <o.mandel@menlosystems.com> | 2023-06-23 12:17:28 +0200 |
| commit | 8e1187363fa82b2fd7d3d23a100b9de28a22ed17 (patch) | |
| tree | 01221503c90b9e1a84ba84c42c87af516357479e /src/qml/jsruntime/qv4qobjectwrapper.cpp | |
| parent | 6856c7ae2c43dcd21d0a6e4a918a138784d0ccb1 (diff) | |
ResolveOverloaded: change qCInfo to qCDebug
Change the message type for the messages on category
qt.qml.overloadresolution from Info to Debug: the messages are intended
for debugging purposes, so an Info message type is "too loud".
Fixes: QTBUG-114643
Pick-to: 6.6
Change-Id: I3d33ea05de24eb98aa736e7c74016a53aa9a00b4
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Diffstat (limited to 'src/qml/jsruntime/qv4qobjectwrapper.cpp')
| -rw-r--r-- | src/qml/jsruntime/qv4qobjectwrapper.cpp | 34 |
1 files changed, 17 insertions, 17 deletions
diff --git a/src/qml/jsruntime/qv4qobjectwrapper.cpp b/src/qml/jsruntime/qv4qobjectwrapper.cpp index b891534712..e8b88d7fc0 100644 --- a/src/qml/jsruntime/qv4qobjectwrapper.cpp +++ b/src/qml/jsruntime/qv4qobjectwrapper.cpp @@ -1846,12 +1846,12 @@ static const QQmlPropertyData *ResolveOverloaded( for (int i = 0; i < methodCount; ++i) { const QQmlPropertyData *attempt = methods + i; - if (lcOverloadResolution().isInfoEnabled()) { + if (lcOverloadResolution().isDebugEnabled()) { const QQmlPropertyData &candidate = methods[i]; const QMetaMethod m = candidate.isConstructor() ? object.metaObject()->constructor(candidate.coreIndex()) : object.metaObject()->method(candidate.coreIndex()); - qCInfo(lcOverloadResolution) << "::: considering signature" << m.methodSignature(); + qCDebug(lcOverloadResolution) << "::: considering signature" << m.methodSignature(); } // QQmlV4Function overrides anything that doesn't provide the exact number of arguments @@ -1867,12 +1867,12 @@ static const QQmlPropertyData *ResolveOverloaded( if (attempt->hasArguments()) { if (attempt->isConstructor()) { if (!object.constructorParameterTypes(attempt->coreIndex(), &storage, nullptr)) { - qCInfo(lcOverloadResolution, "rejected, could not get ctor argument types"); + qCDebug(lcOverloadResolution, "rejected, could not get ctor argument types"); continue; } } else { if (!object.methodParameterTypes(attempt->coreIndex(), &storage, nullptr)) { - qCInfo(lcOverloadResolution, "rejected, could not get ctor argument types"); + qCDebug(lcOverloadResolution, "rejected, could not get ctor argument types"); continue; } } @@ -1880,7 +1880,7 @@ static const QQmlPropertyData *ResolveOverloaded( } if (methodArgumentCount > argumentCount) { - qCInfo(lcOverloadResolution, "rejected, insufficient arguments"); + qCDebug(lcOverloadResolution, "rejected, insufficient arguments"); continue; // We don't have sufficient arguments to call this method } @@ -1888,7 +1888,7 @@ static const QQmlPropertyData *ResolveOverloaded( ? 0 : (definedArgumentCount - methodArgumentCount + 1); if (methodParameterScore > bestParameterScore) { - qCInfo(lcOverloadResolution) << "rejected, score too bad. own" << methodParameterScore << "vs best:" << bestParameterScore; + qCDebug(lcOverloadResolution) << "rejected, score too bad. own" << methodParameterScore << "vs best:" << bestParameterScore; continue; // We already have a better option } @@ -1910,21 +1910,21 @@ static const QQmlPropertyData *ResolveOverloaded( bestParameterScore = methodParameterScore; bestMaxMatchScore = maxMethodMatchScore; bestSumMatchScore = sumMethodMatchScore; - qCInfo(lcOverloadResolution) << "updated best" << "bestParameterScore" << bestParameterScore << "\n" - << "bestMaxMatchScore" << bestMaxMatchScore << "\n" - << "bestSumMatchScore" << bestSumMatchScore << "\n"; + qCDebug(lcOverloadResolution) << "updated best" << "bestParameterScore" << bestParameterScore << "\n" + << "bestMaxMatchScore" << bestMaxMatchScore << "\n" + << "bestSumMatchScore" << bestSumMatchScore << "\n"; } else { - qCInfo(lcOverloadResolution) << "did not update best\n" - << "bestParameterScore" << bestParameterScore << "\t" - << "methodParameterScore" << methodParameterScore << "\n" - << "bestMaxMatchScore" << bestMaxMatchScore << "\t" - << "maxMethodMatchScore" << maxMethodMatchScore << "\n" - << "bestSumMatchScore" << bestSumMatchScore << "\t" - << "sumMethodMatchScore" << sumMethodMatchScore << "\n"; + qCDebug(lcOverloadResolution) << "did not update best\n" + << "bestParameterScore" << bestParameterScore << "\t" + << "methodParameterScore" << methodParameterScore << "\n" + << "bestMaxMatchScore" << bestMaxMatchScore << "\t" + << "maxMethodMatchScore" << maxMethodMatchScore << "\n" + << "bestSumMatchScore" << bestSumMatchScore << "\t" + << "sumMethodMatchScore" << sumMethodMatchScore << "\n"; } if (bestParameterScore == 0 && bestMaxMatchScore == 0) { - qCInfo(lcOverloadResolution, "perfect match"); + qCDebug(lcOverloadResolution, "perfect match"); break; // We can't get better than that } |