diff options
| author | Ulf Hermann <ulf.hermann@qt.io> | 2021-02-12 08:53:00 +0100 |
|---|---|---|
| committer | Ulf Hermann <ulf.hermann@qt.io> | 2021-02-12 10:30:20 +0000 |
| commit | 4cc91a6a0e4f9063233a4d6554ae64855cf99c14 (patch) | |
| tree | 89175c0d09b16926a95c3b1239f73971beacf5bb /src/quick/doc/snippets/qml/loader | |
| parent | eaa9993682f02ef0420ec49b816da27db3ca00c2 (diff) | |
Use functions as signal handlers when accessing parameters
Injected signal handlers are bad practice because they aren't declared.
Pick-to: 6.1
Task-number: QTBUG-89943
Change-Id: I3a691f68342a199bd63034637aa7ed438e3a037b
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Diffstat (limited to 'src/quick/doc/snippets/qml/loader')
| -rw-r--r-- | src/quick/doc/snippets/qml/loader/KeyReader.qml | 2 | ||||
| -rw-r--r-- | src/quick/doc/snippets/qml/loader/connections.qml | 2 | ||||
| -rw-r--r-- | src/quick/doc/snippets/qml/loader/focus.qml | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/src/quick/doc/snippets/qml/loader/KeyReader.qml b/src/quick/doc/snippets/qml/loader/KeyReader.qml index 56604319e0..c68ebf4f1a 100644 --- a/src/quick/doc/snippets/qml/loader/KeyReader.qml +++ b/src/quick/doc/snippets/qml/loader/KeyReader.qml @@ -42,7 +42,7 @@ import QtQuick 2.0 Item { Item { focus: true - Keys.onPressed: { + Keys.onPressed: (event)=> { console.log("KeyReader captured:", event.text); event.accepted = true; diff --git a/src/quick/doc/snippets/qml/loader/connections.qml b/src/quick/doc/snippets/qml/loader/connections.qml index 5ff57a1d38..5b2126a8fd 100644 --- a/src/quick/doc/snippets/qml/loader/connections.qml +++ b/src/quick/doc/snippets/qml/loader/connections.qml @@ -49,7 +49,7 @@ Item { Connections { target: myLoader.item - onMessage: console.log(msg) + function onMessage(msg) { console.log(msg) } } } //![0] diff --git a/src/quick/doc/snippets/qml/loader/focus.qml b/src/quick/doc/snippets/qml/loader/focus.qml index f3509021f1..b59f72c729 100644 --- a/src/quick/doc/snippets/qml/loader/focus.qml +++ b/src/quick/doc/snippets/qml/loader/focus.qml @@ -54,7 +54,7 @@ Rectangle { } } - Keys.onPressed: { + Keys.onPressed: (event)=> { console.log("Captured:", event.text); } |