aboutsummaryrefslogtreecommitdiffstats
path: root/src/quick/items/qquicklistview.cpp
diff options
context:
space:
mode:
authorUlf Hermann <ulf.hermann@qt.io>2022-05-09 17:49:17 +0200
committerUlf Hermann <ulf.hermann@qt.io>2022-05-11 10:06:38 +0200
commitcf9c0f0180b65f0f2ad2cf20a35a3d11a7430927 (patch)
tree8a6c8a475412863c3fa595e98ed163075c3c6304 /src/quick/items/qquicklistview.cpp
parentcc902136c6693b14ac98e41046a2bfecc8f5911b (diff)
Avoid memory leaks in QQuickListView and tst_qqmlinstantiator
Pick-to: 6.2 6.3 Change-Id: Ieceffedb082e893b54bcda99076df3ccdeff6010 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
Diffstat (limited to 'src/quick/items/qquicklistview.cpp')
-rw-r--r--src/quick/items/qquicklistview.cpp4
1 files changed, 3 insertions, 1 deletions
diff --git a/src/quick/items/qquicklistview.cpp b/src/quick/items/qquicklistview.cpp
index c35fc5224c..7ddda6196f 100644
--- a/src/quick/items/qquicklistview.cpp
+++ b/src/quick/items/qquicklistview.cpp
@@ -3749,8 +3749,10 @@ bool QQuickListViewPrivate::applyInsertionChange(const QQmlChangeSet::Change &ch
item = createItem(it.index, QQmlIncubator::Synchronous);
if (!item)
return false;
- if (it.removedAtIndex)
+ if (it.removedAtIndex) {
+ releaseItem(item, reusableFlag);
continue;
+ }
visibleItems.insert(index, item);
if (index == 0)