diff options
| author | Sami Shalayel <sami.shalayel@qt.io> | 2025-11-27 08:58:20 +0100 |
|---|---|---|
| committer | Sami Shalayel <sami.shalayel@qt.io> | 2025-11-27 21:49:24 +0100 |
| commit | 41f221a6139fdf293dc603665d1ecaa94ee37fcd (patch) | |
| tree | a9cd27595f40c4390ede924d9e9585bd1ad2f208 /src | |
| parent | a64522a92671556882166e9cf3e05b3bf775b9ae (diff) | |
qqmldomelement: fix coverity warning
Add const references to the loops to avoid copies.
Change-Id: I08cfc615d5a40e88a41de23750a0416b6309b1dc
Coverity-Id: 897432
Coverity-Id: 897433
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Diffstat (limited to 'src')
| -rw-r--r-- | src/qmldom/qqmldomelements.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/qmldom/qqmldomelements.cpp b/src/qmldom/qqmldomelements.cpp index 0ab33e4fb9..2119cc165e 100644 --- a/src/qmldom/qqmldomelements.cpp +++ b/src/qmldom/qqmldomelements.cpp @@ -870,7 +870,7 @@ static QStringList keepKeysOrder(const QList<std::pair<SourceLocation, DomItem>> const QStringList &keys) { QStringList originalOrderedKeys; - for (auto attrib : attribs) { + for (const auto &attrib : attribs) { QString defName = attrib.second.name(); if (keys.contains(defName) && !originalOrderedKeys.contains(defName)) { originalOrderedKeys.append(defName); @@ -887,7 +887,7 @@ static QList<DomItem> keepDomItemsOrder(const QList<std::pair<SourceLocation, Do QList<DomItem> values = item.values(); QList<DomItem> originalValuesOrder; - for (auto attrib : attribs) { + for (const auto &attrib : attribs) { QString defName = attrib.second.name(); const auto itemValue = item.key(defName); if (values.contains(itemValue) && !originalValuesOrder.contains(itemValue)) { |