aboutsummaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorLuca Di Sera <luca.disera@qt.io>2024-08-30 10:27:51 +0200
committerLuca Di Sera <luca.disera@qt.io>2024-09-02 09:41:17 +0200
commitc320e192113fe9511b394552dc780d2e7ca373d2 (patch)
tree71ff6931e8c2d530e94cf889ceeec959017c695b /src
parentba7223823f78404353622ad38145bc3ec2bc442d (diff)
Fix codechecker `inaccurate-erase` warning
Use `q20::erase` instad of the one-argument overload of erase and the erase-remove idiom. Change-Id: I880cdbdf38df1873fb87522975bcd9e9aaf9c9d4 Reviewed-by: Giuseppe D'Angelo <giuseppe.dangelo@kdab.com>
Diffstat (limited to 'src')
-rw-r--r--src/qml/jsruntime/qv4estable_p.h4
1 files changed, 3 insertions, 1 deletions
diff --git a/src/qml/jsruntime/qv4estable_p.h b/src/qml/jsruntime/qv4estable_p.h
index f25f8edba1..a23e4ad4f2 100644
--- a/src/qml/jsruntime/qv4estable_p.h
+++ b/src/qml/jsruntime/qv4estable_p.h
@@ -17,6 +17,8 @@
#include <vector>
+#include <QtCore/q20vector.h>
+
#include "qv4value_p.h"
class tst_qv4estable;
@@ -64,7 +66,7 @@ public:
m_observers.push_back(&observer);
}
inline void stopObservingShifts(ShiftObserver& observer) {
- m_observers.erase(std::remove(m_observers.begin(), m_observers.end(), &observer));
+ q20::erase(m_observers, &observer);
}
private: