aboutsummaryrefslogtreecommitdiffstats
path: root/src/quickcontrols/basic/ComboBox.qml
Commit message (Collapse)AuthorAgeFilesLines
* Set explicit default security level of all files with default securityJan Arve Sæther2025-09-171-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | The files (folders) already processed are listed in each issue in epic QTBUG-134547 These files were processed half a year ago. In order to make it clear that all of these files are already processed, mark them with an explicit default security header. For the record, this was generated with this script: find -E . -regex ".*\.(cpp|h|hpp|mm|qml|js)$" | xargs python3 ~/bin/add-cra-header.py in the folders listed in each subtask of QTBUG-134547 (add-cra-header.py only exist at my desktop, but it simply adds the default security header if it doesn't already have any existing security header) QUIP: 23 Fixes: QTBUG-134547 Pick-to: 6.10 6.9 6.8 Change-Id: Ieb8c78ea6561fdbdd27c7b13185ece853eedf80f Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
* Basic style: Improve accessibility with high-contrast colorsMohammadHossein Qanbari2025-06-171-3/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch enhances accessibility by introducing high-contrast visual cues across various controls when high-contrast mode is preferred. Previously, controls in the Basic style did not provide sufficient visual distinction in high-contrast mode. This patch adds a visible contour (border) around controls when high-contrast mode is enabled. For some controls, the contour is added by adjusting the border color and width. For others (e.g., highlighted ComboBox items), a Rectangle is drawn around the control. TextArea and Tumbler controls are also updated accordingly. Separator controls now increase their width or height based on orientation in high-contrast mode for better visibility. ScrollBar and ScrollIndicator controls: - Previously, these controls relied solely on handle color changes, which were insufficient in high-contrast mode. - This patch introduces an optional background and increases the handle's contrast to improve visibility. The patch also ensures that text and border colors adapt to the high-contrast palette, improving legibility and focus indication throughout the controls. Minor adjustments to Menu, Delegate, and Header controls for consistent high-contrast appearance. Task-number: QTBUG-135687 Pick-to: 6.10 Change-Id: I460bd6fa2e48a47f20c2ba053ab453f32de18add Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
* ComboBox: fix popup palette inheritance, part twoMitch Curtis2024-06-061-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 0ad15c4101889a22bf9ff761e7d20ec515f46514 fixed the colors of ComboBox's popup, but as a drive-by, tried to simplify several bindings to palette properties. For example: background: Rectangle { color: control.palette.window } became: background: Rectangle { color: palette.window } I'm guessing I thought that the standard Item palette propagation would kick in there and so the "control" part wasn't necessary. If ComboBox.qml's popup had a line like this palette.window: "red" then it would work, because the role is explicitly set. By setting a role in QML, QQuickPaletteColorProvider::m_requestedPalette is set for that item (Popup, in the example above). Just having palette: control.palette isn't enough, because no role has been set and hence m_requestedPalette won't be allocated and it will use the default values. This patch restores the previous code to fix the regression. Fixes: QTBUG-125529 Pick-to: 6.5 6.7 6.8 Change-Id: I2103b81a34d9e7f17992d0355befb8b904134db1 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
* ComboBox: fix popup palette inheritanceMitch Curtis2024-05-081-2/+3
| | | | | | | | | | | | | 54a2a35f17d5e5d1793af63b76993a583e10ab41 fixed the theme/accent/primary inheritance of the Material and Universal style's ComboBox popups. This patch makes an equivalent fix for styles that use palettes. Now the Basic and Fusion ComboBox popups will have the correct colors in both light and dark modes. Fixes: QTBUG-124474 Pick-to: 6.5 6.7 Change-Id: I3e3fcdc9d6fe75f195cc4f4707eac6d30413121f Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
* Controls: Improve various delegatesUlf Hermann2023-03-271-0/+5
| | | | | | | | | Their internal components should be bound, they should use required properties, and they should prefer IDs over the "parent" property. Change-Id: Iac61a4d7b9daf34928a1b41a29658e491e3ac39f Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
* Controls: Remove the model/modelData workaroundsUlf Hermann2023-03-271-1/+1
| | | | | | | | Now that model has modelData as anonymous property and also has useful properties for list models, we can remove the workarounds. Change-Id: I744247821fba3c14e5bfff125daeeb7a3128f3b5 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
* Remove "2" from Qt Quick Controls directoriesMitch Curtis2022-12-011-0/+106
Qt Quick Controls 2 was named that way because it was a follow-up to Qt Quick Controls 1.x. Now that Qt Quick Controls 1 is no longer supported, we don't need to have "2" in the name. Work on this was already started for the documentation in 1abdfe5d5a052f2298b7bf657513dfa7e0c66a56. By doing this renaming a few weeks before feature freeze, it won't affect the release but still results in as little time possible spent manually fixing conflicts in cherry-picks from non-LTS releases as a result of the renaming. This patch does the following: - Renames directories. - Adapts CMakeLists.txt and other files to account for the new paths. A follow-up patch will handle documentation. It does not touch library names or other user-facing stuff, as that will have to be done in Qt 7. Task-number: QTBUG-95413 Change-Id: I170d8db19033ee71e495ff0c5c1a517a41ed7634 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>