An Edit action in ASP.NET MVC, with handling for missing id parameter

Question

I have a standard Edit action in Asp.Net MVC 5 and I want to avoid throwing the unhandled exception when is made a get request without the id like ~/food/edit, so I did this.

public ActionResult Edit(int id = 0)
{
    if (id == 0)
    {
        return new HttpStatusCodeResult(HttpStatusCode.BadRequest);
    }

    string result = _foodAppService.GetById(id);
    FoodVm food = string.IsNullOrEmpty(result) 
        ? null 
        : JsonConvert.DeserializeObject<FoodVm>(result);

    if (food == null)
    {
        return RedirectToAction("Index");
    }

    return View(food);
}

My question is: Is it a good practice to handled it in this way or there are more suitable strategies ?

I'm new to this asking question thing, if a should I ask in another way, just let me know, thank you for your time.

Welcome to Code Review! Some useful resources for making great CR questions include how to get the best value out of CR and Simon's guide for posting a good question - of course there's more, feel free to browse around on meta. Usually reviewees post, say, the controller class, explain what it's for/what the code does, and express various concerns; then reviewers point out anything that can be improved (literally covering any/all aspects of the code). — Mathieu Guindon
– Mathieu Guindon, Commented Sep 13, 2016 at 14:20
it is a good practice, see docs.microsoft.com/en-us/aspnet/mvc/overview/getting-started/… — juFo
– juFo, Commented Mar 19, 2018 at 13:38

JanDotNet · Accepted Answer · 2016-09-14 03:12:09Z

I think "BadRequest" is OK for that case. Alternative options are "PageNotFound" or "redirect to index".

Some other points about your code:

0 is usually a valid ID so I would use -1 as default, even if that is not true in your case.
You could check for null or empty first to simplify the code

.

public ActionResult Edit(int id = -1)
{
    if (id < 0)
    {
        return new HttpStatusCodeResult(HttpStatusCode.BadRequest);
    }

    string result = _foodAppService.GetById(id);
    if (string.IsNullOrEmpty(result))
    {
        return RedirectToAction("Index");
    }

    var food = JsonConvert.DeserializeObject<FoodVm>(result);
    return View(food);
}

Stack Exchange Network

An Edit action in ASP.NET MVC, with handling for missing id parameter

1 Answer 1

You must log in to answer this question.

Hot Network Questions

An Edit action in ASP.NET MVC, with handling for missing id parameter

1 Answer 1

You must log in to answer this question.

Related

Hot Network Questions