aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorElijah Newren <newren@gmail.com>2022-02-02 02:37:36 +0000
committerJunio C Hamano <gitster@pobox.com>2022-02-02 10:02:28 -0800
commit0d83d8240ddb3f54da44563b73527dbc50c4ed22 (patch)
tree7d526d3d68f583d8f38d037606fee6fcb7660e79
parent20323d104ec389505e83b9376c8ecab94e852fb8 (diff)
downloadgit-0d83d8240ddb3f54da44563b73527dbc50c4ed22.tar.gz
merge-ort: mark conflict/warning messages from inner merges as omittable
A recursive merge involves merging the merge bases of the two branches being merged. Such an inner merge can itself generate conflict notices. While such notices may be useful when initially trying to create a merge, they seem to just be noise when investigating merges later with --remerge-diff. (Especially when both sides of the outer merge resolved the conflict the same way leading to no overall conflict.) Remove them. Signed-off-by: Elijah Newren <newren@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rw-r--r--merge-ort.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/merge-ort.c b/merge-ort.c
index 43f980d258..9bf15a01db 100644
--- a/merge-ort.c
+++ b/merge-ort.c
@@ -638,7 +638,9 @@ static void path_msg(struct merge_options *opt,
struct strbuf tmp = STRBUF_INIT;
if (opt->record_conflict_msgs_as_headers && omittable_hint)
- return; /* Do not record mere hints in tree */
+ return; /* Do not record mere hints in headers */
+ if (opt->record_conflict_msgs_as_headers && opt->priv->call_depth)
+ return; /* Do not record inner merge issues in headers */
sb = strmap_get(&opt->priv->output, path);
if (!sb) {
sb = xmalloc(sizeof(*sb));