diff options
| author | Patrick Steinhardt <ps@pks.im> | 2024-11-05 07:17:06 +0100 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2024-11-04 22:37:53 -0800 |
| commit | 3b373150c8ea52ed64db0e7b0bd5a9b483e99a8e (patch) | |
| tree | c25c77b5ca13c2f674ce4e88a2a98d202204d01c | |
| parent | 0b20a28811390ad8a1f7e22928018e5241738446 (diff) | |
| download | git-3b373150c8ea52ed64db0e7b0bd5a9b483e99a8e.tar.gz | |
upload-pack: fix leaking URI protocols
We don't clear `struct upload_pack::uri_protocols`, which causes a
memory leak. Fix this.
Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rwxr-xr-x | t/t5702-protocol-v2.sh | 1 | ||||
| -rw-r--r-- | upload-pack.c | 1 |
2 files changed, 2 insertions, 0 deletions
diff --git a/t/t5702-protocol-v2.sh b/t/t5702-protocol-v2.sh index d3df81e785..e4ce059236 100755 --- a/t/t5702-protocol-v2.sh +++ b/t/t5702-protocol-v2.sh @@ -7,6 +7,7 @@ TEST_NO_CREATE_REPO=1 GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME +TEST_PASSES_SANITIZE_LEAK=true . ./test-lib.sh # Test protocol v2 with 'git://' transport diff --git a/upload-pack.c b/upload-pack.c index 6d6e0f9f98..b4a59c3518 100644 --- a/upload-pack.c +++ b/upload-pack.c @@ -166,6 +166,7 @@ static void upload_pack_data_clear(struct upload_pack_data *data) object_array_clear(&data->extra_edge_obj); list_objects_filter_release(&data->filter_options); string_list_clear(&data->allowed_filters, 0); + string_list_clear(&data->uri_protocols, 0); free((char *)data->pack_objects_hook); } |