diff options
| author | Patrick Steinhardt <ps@pks.im> | 2024-09-05 12:08:53 +0200 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2024-09-05 08:49:11 -0700 |
| commit | 3eefd348e5865b0406d32194a157ae77d9a7939b (patch) | |
| tree | f65599e328299448b05394423ec577126ea88839 | |
| parent | ac2e7d545efdc4ceeef8c1191bb276e86d793f29 (diff) | |
| download | git-3eefd348e5865b0406d32194a157ae77d9a7939b.tar.gz | |
submodule: fix leaking fetch task data
The `submodule_parallel_fetch` structure contains various data
structures that we use to set up parallel fetches of submodules. We do
not free some of its data though, causing memory leaks. Plug those.
Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | submodule.c | 2 | ||||
| -rwxr-xr-x | t/t5526-fetch-submodules.sh | 1 |
2 files changed, 3 insertions, 0 deletions
diff --git a/submodule.c b/submodule.c index 97516b0fec..97d0d47b56 100644 --- a/submodule.c +++ b/submodule.c @@ -1883,6 +1883,8 @@ int fetch_submodules(struct repository *r, out: free_submodules_data(&spf.changed_submodule_names); string_list_clear(&spf.seen_submodule_names, 0); + strbuf_release(&spf.submodules_with_errors); + free(spf.oid_fetch_tasks); return spf.result; } diff --git a/t/t5526-fetch-submodules.sh b/t/t5526-fetch-submodules.sh index 5e566205ba..2cfb5bd6bb 100755 --- a/t/t5526-fetch-submodules.sh +++ b/t/t5526-fetch-submodules.sh @@ -6,6 +6,7 @@ test_description='Recursive "git fetch" for submodules' GIT_TEST_FATAL_REGISTER_SUBMODULE_ODB=1 export GIT_TEST_FATAL_REGISTER_SUBMODULE_ODB +TEST_PASSES_SANITIZE_LEAK=true . ./test-lib.sh pwd=$(pwd) |