aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJunio C Hamano <gitster@pobox.com>2025-05-30 11:59:16 -0700
committerJunio C Hamano <gitster@pobox.com>2025-05-30 11:59:17 -0700
commit5cde0d782549a4ba4e926c74a61c094092b50367 (patch)
treec74af3803b16a268a6af6d67a72f5e8cf8b0b0de
parent8ddea85fd7a13cd40f33c6dd54ed43b1a5f47d5e (diff)
parent67cae845d21d3ca0dbdb51ecebb695b175fd1c8e (diff)
downloadgit-5cde0d782549a4ba4e926c74a61c094092b50367.tar.gz
Merge branch 'op/cvsserver-perl-warning'
Recent versions of Perl started warning against "! A =~ /pattern/" which does not negate the result of the matching. As it turns out that the problematic function is not even called, it was removed. * op/cvsserver-perl-warning: cvsserver: remove unused escapeRefName function
-rwxr-xr-xgit-cvsserver.perl27
1 files changed, 3 insertions, 24 deletions
diff --git a/git-cvsserver.perl b/git-cvsserver.perl
index a4e1bad33c..d8d5422cbc 100755
--- a/git-cvsserver.perl
+++ b/git-cvsserver.perl
@@ -4986,13 +4986,13 @@ sub gethistorydense
return $result;
}
-=head2 escapeRefName
+=head2 unescapeRefName
-Apply an escape mechanism to compensate for characters that
+Undo an escape mechanism to compensate for characters that
git ref names can have that CVS tags can not.
=cut
-sub escapeRefName
+sub unescapeRefName
{
my($self,$refName)=@_;
@@ -5009,27 +5009,6 @@ sub escapeRefName
# = "_-xx-" Where "xx" is the hexadecimal representation of the
# desired ASCII character byte. (for anything else)
- if(! $refName=~/^[1-9][0-9]*(\.[1-9][0-9]*)*$/)
- {
- $refName=~s/_-/_-u--/g;
- $refName=~s/\./_-p-/g;
- $refName=~s%/%_-s-%g;
- $refName=~s/[^-_a-zA-Z0-9]/sprintf("_-%02x-",$1)/eg;
- }
-}
-
-=head2 unescapeRefName
-
-Undo an escape mechanism to compensate for characters that
-git ref names can have that CVS tags can not.
-
-=cut
-sub unescapeRefName
-{
- my($self,$refName)=@_;
-
- # see escapeRefName() for description of escape mechanism.
-
$refName=~s/_-([spu]|[0-9a-f][0-9a-f])-/unescapeRefNameChar($1)/eg;
# allowed tag names