aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJunio C Hamano <gitster@pobox.com>2024-06-08 11:37:44 -0700
committerJunio C Hamano <gitster@pobox.com>2024-06-10 09:16:19 -0700
commit89e78c7cdad1ac70d16c0ceb79b3ff95dfadd2bb (patch)
treee82de69b4b5359104d15d1937c7bc7f7f4bb90a8
parent786a3e4b8d754d2b14b1208b98eeb0a554ef19a8 (diff)
downloadgit-89e78c7cdad1ac70d16c0ceb79b3ff95dfadd2bb.tar.gz
__attribute__: trace2_region_enter_printf() is like "printf"
The last part of the parameter list the function takes is like parameters to printf. Mark it as such. An existing call that formats a value of type size_t using "%d" was found by the compiler with the help with this annotation; fix it. Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rw-r--r--run-command.c3
-rw-r--r--trace2.h1
2 files changed, 3 insertions, 1 deletions
diff --git a/run-command.c b/run-command.c
index 1b821042b4..ec2c12e98b 100644
--- a/run-command.c
+++ b/run-command.c
@@ -1753,7 +1753,8 @@ void run_processes_parallel(const struct run_process_parallel_opts *opts)
if (do_trace2)
trace2_region_enter_printf(tr2_category, tr2_label, NULL,
- "max:%d", opts->processes);
+ "max:%"PRIuMAX,
+ (uintmax_t)opts->processes);
pp_init(&pp, opts, &pp_sig);
while (1) {
diff --git a/trace2.h b/trace2.h
index 1f0669bbd2..19e04bf040 100644
--- a/trace2.h
+++ b/trace2.h
@@ -390,6 +390,7 @@ void trace2_region_enter_printf_va_fl(const char *file, int line,
trace2_region_enter_printf_va_fl(__FILE__, __LINE__, (category), \
(label), (repo), (fmt), (ap))
+__attribute__((format (printf, 6, 7)))
void trace2_region_enter_printf_fl(const char *file, int line,
const char *category, const char *label,
const struct repository *repo,