diff options
| author | Jeff King <peff@peff.net> | 2024-09-24 17:58:00 -0400 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2024-09-25 10:24:54 -0700 |
| commit | d121a7dd21a58a749b7640d23888ddac27c577c9 (patch) | |
| tree | d154a18c0695b67fb4cf8a16bfacbd34b3c27d2f | |
| parent | ea4780307cc5007c6136ed216d45841d21ccfe75 (diff) | |
| download | git-d121a7dd21a58a749b7640d23888ddac27c577c9.tar.gz | |
fetch-pack: clear pack lockfiles list
If the --lock-pack option is passed (which it typically is when
fetch-pack is used under the hood by smart-http), then we may end up
with entries in our pack_lockfiles string_list. We need to clear them
before returning to avoid a leak.
In git-fetch this isn't a problem, since the same cleanup happens via
transport_unlock_pack(). But the leak is detectable in t5551, which does
http fetches.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | builtin/fetch-pack.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/builtin/fetch-pack.c b/builtin/fetch-pack.c index ef4143eef3..62e8c3aa6b 100644 --- a/builtin/fetch-pack.c +++ b/builtin/fetch-pack.c @@ -295,5 +295,6 @@ int cmd_fetch_pack(int argc, free_refs(remote_refs); list_objects_filter_release(&args.filter_options); oid_array_clear(&shallow); + string_list_clear(&pack_lockfiles, 0); return ret; } |