diff options
| author | Chandra Pratap <chandrapratap3519@gmail.com> | 2024-05-29 22:29:31 +0530 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2024-05-30 07:30:10 -0700 |
| commit | efa8786800618b4119536d2af8f0bbcfa86b1c04 (patch) | |
| tree | e5c2a56debdfb5c75a9e4b7d11c0652ea07a928e | |
| parent | e31efffc28b2d22137587ba9c0c71f03713df4b9 (diff) | |
| download | git-efa8786800618b4119536d2af8f0bbcfa86b1c04.tar.gz | |
t: improve the test-case for parse_names()
In the existing test-case for parse_names(), the fact that empty
lines should be ignored is not obvious because the empty line is
immediately followed by end-of-string. This can be mistaken as the
empty line getting replaced by NULL. Improve this by adding a
non-empty line after the empty one to demonstrate the intended behavior.
Mentored-by: Patrick Steinhardt <ps@pks.im>
Mentored-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Chandra Pratap <chandrapratap3519@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | t/unit-tests/t-reftable-basics.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/t/unit-tests/t-reftable-basics.c b/t/unit-tests/t-reftable-basics.c index 3c08218257..529049af12 100644 --- a/t/unit-tests/t-reftable-basics.c +++ b/t/unit-tests/t-reftable-basics.c @@ -89,11 +89,13 @@ static void test_parse_names_normal(void) static void test_parse_names_drop_empty(void) { - char in[] = "a\n\n"; + char in[] = "a\n\nb\n"; char **out = NULL; parse_names(in, strlen(in), &out); check_str(out[0], "a"); - check(!out[1]); + /* simply '\n' should be dropped as empty string */ + check_str(out[1], "b"); + check(!out[2]); free_names(out); } |